neofetch icon indicating copy to clipboard operation
neofetch copied to clipboard

neofetch: Strengthen scoop/choco app reporting

Open rasa opened this issue 4 years ago • 5 comments
trafficstars

Description

This PR enhances scoop and chocolatey package reporting, as it:

  1. Uses cygpath to determine where drive C: is mounted (while defaulting to /cygdrive/c).
  2. Finds Scoop's package directories if installed in non-standard directories.
  3. Processes both Scoop's local (user) and system (global) installed packages.
  4. Reports the above package counts separately.
  5. Reports chocolatey's package count separately.

Tested and working in Cygwin, Msys2, git-bash, and WSL environments, where C: is mounted at /c and both %SCOOP% and %SCOOP_GLOBAL% are used.

rasa avatar Dec 27 '20 06:12 rasa

What happens when cygpath is unavailable? (Is it available if CYGWIN is absent? ie, just wsl or msys2 etc).

dylanaraps avatar Jun 11 '21 05:06 dylanaraps

What happens when cygpath is unavailable? (Is it available if CYGWIN is absent? ie, just wsl or msys2 etc).

Cygwin, msys2, mingw, and git-bash environments all have cygpath and /proc/mounts. But if cygpath fails to be found in the path, the code will default to the existing functionality, i.e., using /cygdrive/c/ProgramData.

While wsl runs under Windows, it does not have scoop or choco available, so none of this code is executed.

rasa avatar Jul 01 '21 05:07 rasa

@dylanaraps Why is this PR labeled as "Not mergeable"?

rasa avatar Sep 08 '21 16:09 rasa

@dylanaraps Why is this PR labeled as "Not mergeable"?

@dylanaraps Ping.

rasa avatar Nov 07 '21 20:11 rasa

Thank you for your contribution!

This PR is merged into hyfetch since this repo (dylanaraps/neofetch) seems no longer maintained.

HyFetch is a fork of neofetch with LGBTQ pride flags, but the repo also maintains an updated version of the original neofetch, addressing many pull requests that are not merged in the original repo.

Read the "Running Updated Original Neofetch" section for more info!

hykilpikonna avatar Aug 12 '22 04:08 hykilpikonna