online-devops-dojo icon indicating copy to clipboard operation
online-devops-dojo copied to clipboard

Add a final step in final module to remove PAT

Open ojacques opened this issue 5 years ago • 8 comments

Is your feature request related to a problem? Please describe.

When a student ends all the modules, the GitHub Personal Access Token is no more required. It would be nice to have a final step or maybe a final module to remove the PAT from the account.

ojacques avatar Mar 27 '20 12:03 ojacques

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs.

github-actions[bot] avatar Apr 15 '20 06:04 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs.

github-actions[bot] avatar May 21 '20 06:05 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs.

github-actions[bot] avatar Jul 07 '20 06:07 github-actions[bot]

Does the PAT we're asking the students to make have sufficient scope to delete itself?

cpswan avatar Dec 17 '20 17:12 cpswan

On github.com, there is no API endpoint to add or remove a PAT. This has to be done through the UI which can only be accessed with login/password.

pberthonneau avatar Dec 18 '20 19:12 pberthonneau

We may now be able to leverage oauth to get a Personal Access Token. This just released GO library could do what we need and offer a better experience: https://github.com/cli/oauth

ojacques avatar Dec 20 '20 21:12 ojacques

We provided the instructions for the student to create the PAT, I think it would be a good idea to add a Final module.

Ideas

1 - Thank you for taking the Dojo 2 - Very high level summary of what was covered(basically a list of the modules and a list of the learning objectives per module 3 - Small quiz (two questions or 3 questions per module, students would be informed which modules they may need to revisit 4 - Housekeeping - Instructions to delete the PAT and why

tom-halpin avatar Dec 21 '20 12:12 tom-halpin

We could also invite people to share feedback in the new discussion tab. It is enabled with default in online-devops-dojo, but we could instead enable it in about-devops-dojo.

pberthonneau avatar Dec 21 '20 16:12 pberthonneau