redis-connection
redis-connection copied to clipboard
dwyl
[feature] - Add rejson bindings
Feature:
- Add rejson bindings for redis in case ENABLE_REJSON flag is set in process.env
Use Case:
- Can be used to enable rejson commands with redis client for those using rejson module
@nelsonic Hey. Can you please check this pull request and let me know if it can be merged since I need to use ReJSON with my project.
The tests seem to be failing for some reason even without any changes. I have added a test for my changes as well.
@codeslayer1 thanks for opening this feature/pull request. 👍
Indeed the tests failing is a "blocker" to us merging this PR.
https://travis-ci.org/dwyl/redis-connection/builds/461732661
is rather cryptic in how it's failing ... I will investigate when I get back to my desk. Meanwhile are you able to use a local version in your project to tide you over?
Hey. Thanks for your quick response.
Yes. I was able to use ReJSON with my local build. Since I needed this feature urgently, I have published a forked package on npm with rejson (redis-connection-manager). Will revert back to this package once the pull request is merged and an updated version is published.
Please let me know in case any help/update is needed at my end to make the tests pass and get this PR merged.
Hey. I have raised a fresh pull request with the Readme and package.json changes that pertain to my package reverted. Please use that new pull request to merge the rejson change. You can delete this pull request.