learn-elm-architecture-in-javascript icon indicating copy to clipboard operation
learn-elm-architecture-in-javascript copied to clipboard

Review with "Beginner's Mind" #22

Open ghost opened this issue 8 years ago • 6 comments
trafficstars

"@edwardcodes please can you read through the instructions in this tutorial, try the examples and open any issues when anything is unclear? (thanks!)"

@nelsonic i´ve read through the instructions in this (awesome) tutorial (_the reasons to learn elm are very clear and very captivating) and tried the examples (explaining why the code is there and the meaning with the step-by-step comments is MEGA useful 🥇) but there´s a few things i didn't understand:

"9.1 Tests for Resetting the Counter (Update)" "9.4 Write View (UI) Tests"

I didn't´t understand were do i put/write the tests in the script.. besides that everything is clear, each function (mount, signal, update, empty, button and view) has their own purpose in the app, we should use "pure" functions so we can have more control of the outputs (the "impure" js can be tricky).

ghost avatar May 18 '17 14:05 ghost

@edwardcodes this is very helpful feedback! (thanks) image Does indeed not specify where someone should write the tests. It's implied in the previous section, but we should be specific to make it clearer for beginners. https://github.com/dwyl/learn-elm-architecture-in-javascript/tree/09e7bf6d85e5dbee51f7fce0ec6428d4eb60a15e

Did you personally understand where the test was meant to go? Were you able to complete the exercise despite the lack of clear instruction as to exactly where the test and corresponding code should go?

nelsonic avatar May 20 '17 08:05 nelsonic

@nelsonic Thank you! Yes i was able to complete the exercise by adding those 3 lines of code in the gif.image (var Res = 'reset';_ case Res: return 0; _button('Reset', signal, Res)) although i understood where the tests should be (update function) i still have doubts as to "where the test and corresponding code should go?" as to where to place them.. https://github.com/dwyl/learn-tdd

ghost avatar May 20 '17 11:05 ghost

@edwardcodes after completing the learn-tdd tutorial was it clearer where the tests should go?

nelsonic avatar May 21 '17 12:05 nelsonic

@nelsonic i´m still doing the learn-tdd but yes !

ghost avatar May 21 '17 12:05 ghost

@edwardcodes were you able to finish learn-tdd? (as usual please ask questions if/when you get stuck! thanks!)

nelsonic avatar May 24 '17 08:05 nelsonic

@nelsonic I wasn't but I'm going to open an issue with the questions i have!!

ghost avatar May 24 '17 09:05 ghost