transfer.sh icon indicating copy to clipboard operation
transfer.sh copied to clipboard

Published 20 hours ago • verified publisher icon dutchcoders

Footer links don't work

Open dmitrizzle opened this issue 4 years ago • 8 comments

Hey guys, I'm just passing on a found bug here. I don't use transfer.sh personally, but I received a file from someone who does and noticed that none of the footer links, incl. the donation button work on the file download page. Using latest Chrome on macOS.

dmitrizzle avatar Apr 06 '21 23:04 dmitrizzle

@stefanbenten can you check this?

The only broken link I could find on two Chrome based browsers was the "Contact Us"

aspacca avatar Apr 07 '21 08:04 aspacca

The Contact Us Button is definitely broken/not working as it redirects to an non existing page. Besides that the donation button only seems to work when your browser recognizes bitcoin:XXX as app target. Tools like Metamask would do that. I never touched that part of the code, but might be good to do @aspacca ?

stefanbenten avatar Apr 07 '21 15:04 stefanbenten

Here's a GIF. I haven't looked in to it but it seems like a JS or HTML structure issue. These links work fine on homepage. Apr-07-2021 09-32-36

dmitrizzle avatar Apr 07 '21 16:04 dmitrizzle

@dmitrizzle could you share Chrome build and macOS version? thanks

@stefanbenten https://github.com/dutchcoders/transfer.sh-web this is the repo for the frontend. We could also remove some of the links (like the bitcoin donation etc). "Contact Us" should be probably rendered only if a param is passed to the binary, using a mailto:paramValue or similar

aspacca avatar Apr 07 '21 16:04 aspacca

I just checked it myself on Windows and Ubuntu 20.04 with Chrome and both show the Donate link and the misconfigured blog link. The founded in Holland is just a photo, not an actual link @dmitrizzle .

@aspacca I'll see if i can update the respective pieces later today.

stefanbenten avatar Apr 07 '21 16:04 stefanbenten

If you still need the info: Chrome: Version 89.0.4389.114 (Official Build) (x86_64) macOS Mojave: 10.14.6 (18G8022)

dmitrizzle avatar Apr 07 '21 23:04 dmitrizzle

@dmitrizzle tested same chrome build on macOS Catalina 10.15.7, all the links work (btw, Founded in Holland is not a link :))

could you ask your friend if there's any error in the network tab or in the console? it might either something in the frontend that triggers on your friend specific setup, or something in your friend setup totally unrelated to the website

aspacca avatar Apr 08 '21 09:04 aspacca

oki, it's the download page, not the homepage. I missed it in the first place.

@stefanbenten I can reproduce the bug on the donwload page https://transfer.sh/zxXKM/hello.txt with a chrome based browser. the html seems fine

@dmitrizzle thanks, no need to collect any more data :)

aspacca avatar Apr 08 '21 09:04 aspacca