gridster.js icon indicating copy to clipboard operation
gridster.js copied to clipboard

Grunt & Development

Open rwoody opened this issue 12 years ago • 5 comments

After doing a fresh clone of the repo, I noticed that you can't build the project via Grunt for a number of reasons to do with grunt-jslint:

  1. grunt-jslint is not a development dependency in package.json
  2. grunt-jslint causes building to fail miserably, with over 100 errors
  3. There are no qunit tests, which is killing the grunt command

Should we remove these problems to make development possible, or am I missing something?

rwoody avatar May 29 '13 03:05 rwoody

We can remove it for now, in three weeks I launch my new site/app and I'll be doing a lot more work on this.

On Tue, May 28, 2013 at 8:00 PM, Ryan Wood [email protected] wrote:

After doing a fresh clone of the repo, I noticed that you can't build the project via Grunt for a number of reasons to do with grunt-jslint:

  1. grunt-jslint is not a development dependency in package.json
  2. grunt-jslint causes building to fail miserably, with over 100 errors
  3. There are no qunit tests, which is killing the grunt command

Should we remove these problems to make development possible, or am I missing something?

Reply to this email directly or view it on GitHub: https://github.com/dustmoo/gridster.js/issues/15

dustmoo avatar May 29 '13 03:05 dustmoo

Ryan, I'll go ahead and give you powers to commit here since I can't on the original repo.

On Tue, May 28, 2013 at 8:00 PM, Ryan Wood [email protected] wrote:

After doing a fresh clone of the repo, I noticed that you can't build the project via Grunt for a number of reasons to do with grunt-jslint:

  1. grunt-jslint is not a development dependency in package.json
  2. grunt-jslint causes building to fail miserably, with over 100 errors
  3. There are no qunit tests, which is killing the grunt command

Should we remove these problems to make development possible, or am I missing something?

Reply to this email directly or view it on GitHub: https://github.com/dustmoo/gridster.js/issues/15

dustmoo avatar May 29 '13 03:05 dustmoo

Awesome, I'll send those fixes in then

rwoody avatar May 29 '13 03:05 rwoody

I've simply removed some code - assuming this issue good, we should merge and open separate issues to implement tests and fix jslint issues.

rwoody avatar May 29 '13 03:05 rwoody

I agree, I have added you as a collaborator here, you should be able to manage issues and commit directly to the repo.

Cheers.

dustmoo avatar May 29 '13 03:05 dustmoo