update-in icon indicating copy to clipboard operation
update-in copied to clipboard

Published 20 hours ago • verified publisher icon dustingetz

push is really concat

Open dustingetz opened this issue 9 years ago • 1 comments
trafficstars

dustingetz avatar Nov 29 '15 18:11 dustingetz

Daniel Miladinov - 8:11 AM So I’m looking at your update-in issue, push is concat - https://github.com/dustingetz/update-in/issues/2 Do you want to add concat as an alias to push, or replace push with concat altogether (I imagined I’d still call out to react-addons/update:$push underneath, because it’s doing the right thing)

Dustin Getz - 8:33 AM the isuse i believe is that addons.$push takes an array argument which confuses me and everyone else when we intuitively pass it a value and it fails

Dustin Getz - 8:49 AM however the change i suggest in that issue breaks backwards compat, so i dont know, i will need to at least consult Andrew

dustingetz avatar Feb 29 '16 14:02 dustingetz