Change the caching of icons

[bynect]

[bynect]

#586

[codecov-commenter]

:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

:x: Patch coverage is 61.11111% with 28 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 64.75%. Comparing base (d0f8976) to head (f0506a0). :warning: Report is 22 commits behind head on master.

Files with missing lines	Patch %	Lines
src/notification.c	40.00%	12 Missing :warning:
src/queues.c	33.33%	10 Missing :warning:
src/utils.c	63.63%	4 Missing :warning:
src/draw.c	0.00%	1 Missing :warning:
src/x11/x.c	0.00%	1 Missing :warning:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1473      +/-   ##
==========================================
- Coverage   64.83%   64.75%   -0.09%     
==========================================
  Files          51       51              
  Lines        9010     9053      +43     
  Branches     1055     1066      +11     
==========================================
+ Hits         5842     5862      +20     
- Misses       3168     3191      +23     

Flag	Coverage Δ
unittests	64.75% <61.11%> (-0.09%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bynect]

this is not working out the way I intended. maybe icon_id should be scrapped altogether..

[bynect]

@fwsmit if you have the time could you check if these changes are sound? the testing does work, but I did change some pretty critical parts