dunst icon indicating copy to clipboard operation
dunst copied to clipboard

Remove default icons and refactor icon-lookup

Open bynect opened this issue 1 year ago • 2 comments

As requested by #1364 and #1358. I also refactored the search function to provide more informative logging

bynect avatar Jul 01 '24 13:07 bynect

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 25.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 66.07%. Comparing base (b23a2d3) to head (712fe73).

Files Patch % Lines
src/icon.c 24.24% 25 Missing :warning:
src/option_parser.c 0.00% 1 Missing :warning:
src/settings.c 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1365      +/-   ##
==========================================
- Coverage   66.08%   66.07%   -0.01%     
==========================================
  Files          50       50              
  Lines        8247     8228      -19     
  Branches      965      966       +1     
==========================================
- Hits         5450     5437      -13     
+ Misses       2797     2791       -6     
Flag Coverage Δ
unittests 66.07% <25.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 01 '24 13:07 codecov-commenter

some cleanup

bynect avatar Jul 01 '24 14:07 bynect

@fwsmit does it looks good? can I merge?

bynect avatar Jul 09 '24 14:07 bynect

@fwsmit does it looks good? can I merge?

Yeah, looks good. You can go ahead and merge

fwsmit avatar Jul 14 '24 15:07 fwsmit

@fwsmit does it looks good? can I merge?

Yeah, looks good. You can go ahead and merge

perfect 👍🏻

bynect avatar Jul 15 '24 09:07 bynect