Anh-Dung Phan

Results 52 comments of Anh-Dung Phan
trafficstars

From the scenario you described, what is needed is a simple way to add the same reference to multiple projects that is orthogonal to this feature. This feature is purely...

My opposition to this issue is due to the messy VFT project system that we shouldn't touch. @vasily-kirichenko Do you still want to do this or can we close the...

We haven't had this issue when `Tokenize` functions are called on UI thread. Do you know when this issue occurs? If it's a threading issue, it may happen quite frequently.

Well, I didn't think of this case. We chose to show "resolve unopened" smart tag only for the first identifier in an island, which is wrong here. We should allow...

I understand. It's one of the most complex parts in the code base.

Hehe, it wasn't a complaint. Complexity is mostly due to nature of the task.

Hi Ben, You're right; this needs some modifications in FCS. Currently FCS uses `AccessibleFromSomeFSharpCode` which is lowest common denominator for accessibility https://github.com/fsharp/FSharp.Compiler.Service/blob/9a3fc667180ab0a04ee68d341804d40b9d34a008/src/fsharp/vs/Symbols.fs#L410. It hasn't yet to check for `InternalsVisibleTo` attributes....

Could you open an issue in FCS repo with more information? Handling event symbols has some inconsistencies from early days.