Kévin Dunglas comments

Results 764 comments of


                                            Kévin Dunglas

Avoid `webDriver->quit()` on `__destruct()` when scraping remote websites

IMHO it would be better to fix the bug for everybody without asking the user to write custom code.

Adding Port

I would prefer adding a more generic section explaining how to pass options to the drivers, similar to the existing `Passing Arguments to ChromeDriver` section. WDYT?

Adding Port

Maybe should we just move these docs in `symfony/symfony-docs`? Panther reached 1.0 anyway, so it's probably the good time. WDYT @symfony/team-symfony-docs?

Code coverage compliance?

As it browses the app through a web server, coverage will not work by default. It's probably possible to hack something, but it's not on my todo list for now....

Code coverage compliance?

Actually, it would be possible to use a hack similar to this one: https://github.com/api-platform/core/blob/master/features/bootstrap/CoverageContext.php

Code coverage compliance?

If one of you guys can add it to the docs, it would be awesome!

XPath nth element selector is treated as CSS, and is invalid

Good catch. Maybe could we introduce a new parameter to force the selector to be interpreted as `xpath`?

XPath nth element selector is treated as CSS, and is invalid

This works for me. Do you want to open a PR?

Run multiple instances in parallel?

It would be nice to find a fix to be able to test apps using Mercure.

Panther doesn't work with bootstrap 5 => 'Click intercepted' because of scroll (see repository)

In my opinion this should be reported to Bootstrap, and documented in the readme. But we'll not implement non-standard behaviors of third party libraries directly in Panther.