sonos icon indicating copy to clipboard operation
sonos copied to clipboard

Alarm::constructor uses depreciated XmlParser

Open pkolmann opened this issue 9 months ago • 1 comments

I try to use your library and saw that creating a new Alarm uses a depreciated class:

https://github.com/duncan3dc/sonos/blob/cd4e9617888d727b13dc5c6e9cf3fbb68dabe894/src/Alarm.php#L53

See: https://github.com/duncan3dc/domparser/blob/master/bc/XmlElement.php

Do you plan to update your library to change this to the new Element class?

pkolmann avatar Mar 01 '25 15:03 pkolmann

Hi @pkolmann yes it looks like version 2 has been out for a few years now, and supports as far back as PHP 7.2 (further than this library) so I'll look at moving to the new code soon, thanks for the reminder!

duncan3dc avatar Mar 07 '25 10:03 duncan3dc