vue-webpack-typescript icon indicating copy to clipboard operation
vue-webpack-typescript copied to clipboard

Upgrade to webpack 4, TypeScript 3, and many other packages.

Open NoahLE opened this issue 7 years ago • 1 comments

Hi Mr. Levy,

Thank you for building such an awesome boilerplate! I wanted to test this out for a project and thought I would be helpful to share the updates I made.

I have a couple notes about this PR:

  1. For the project pages / components, why did you chose the technique you did, rather than using the single file component structure?

  2. When linting, this warning pops up which I assume will be fixed when TSLint updates to support TypeScript 3. I think it's related to this PR discussion and a hacky workaround is here (which I left out).

no-unused-variable is deprecated. Since TypeScript 2.9. Please use the built-in compiler checks instead.
  1. I noticed these warnings popped up in both code versions and I think it's related to tslint-config-standard, but I couldn't find a great way to get rid of them besides using a different TSLint config.
Warning: The 'await-promise' rule requires type information.
Warning: The 'deprecation' rule requires type information.
Warning: The 'no-unused-variable' rule requires type information.
Warning: The 'no-use-before-declare' rule requires type information.
Warning: The 'no-floating-promises' rule requires type information.
Warning: The 'no-unnecessary-qualifier' rule requires type information.
Warning: The 'no-unnecessary-type-assertion' rule requires type information.
Warning: The 'strict-type-predicates' rule requires type information.

Let me know if this looks good or if there's anything you'd like me to change!

NoahLE avatar Aug 16 '18 20:08 NoahLE

"rules": { "no-unnecessary-type-assertion": null, "no-for-in-array": null, "no-unbound-method": null, "return-undefined": null, "no-unused-variable": null, "no-use-before-declare": null, "deprecation": null },

kwey avatar Nov 01 '18 07:11 kwey