David Tschumperlé

Results 175 comments of David Tschumperlé

So, https://github.com/dtschump/CImg/commit/193abd7b29f3686840a48702d26aa3bf29deac3e is a start :)

To me, it has been fixed already. See https://huntr.dev/bounties/a5e4fc45-8f14-4dd1-811b-740fc50c95d2/

Hello Steffen, You are absolutely right. And you are not the first to tell me that. The fact is that I actually (try to) manage two open-source projects, [CImg](http://cimg.eu/) and...

> Even if you're in a hurry, you do the commits with a goal in mind, so I think you can write that goal as a one-liner in the commit...

Your code does not compile.

> `CImg picture(image->y,image->ywide,image->yhigh,1,1,true);` Why not specifying `3` for the `spectrum` argument of the constructor if you want a color image ?

It seems that NV12 buffers have sub-sampled chromas, so taking the raw NV12 buffer by itself cannot be done directly I suppose. You should at least double-up the chroma resolution...

It's always possible to use CImg to read your 3 components independently (using 3 constructors like the one you used), then reconstruct the color image, something like ~~~~ CImg Y(ptr_luma,W,H,1,1,false);...

Looks like a duplicate of https://github.com/dtschump/CImg/issues/347

After investigation, it appears httplib include `resolv.h` which define macro `_res` (l.162). CImg uses `_res` as a variable name which creates the conflict. Defining `_res` as a macro is really...