react-trix
react-trix copied to clipboard
dstpierre
Is there a reason why `mergeTags` is required?
I am trying to test this out for a use case, I don't think I would need mergeTags props as a functionality. If you could advise on how to get around it or the reason why it's a required prop.
@claeusdev good question. In fact there's no reason at all why the mergeTags property is required.
I've done a quick look at the code and it seems it might be turned optional, specifically line:125 should work for null property.
Since you mention wanting to check at #53 feel free to add this property optional in a separate PR please and if you have a chance to test it out when not specifying a value that all is good, that'd be great.
Alright, sounds great. Also, I realized some tooling would be helpful for contributors. ie. my current setup is set to format on save, upon trying to open a PR, I realized that some formatting has changed? Do we keep on with this or do you think it would be great to have some basic config setup?
@claeusdev might be a good option yes, would prevent from having changes that do not relate to a PR but are just formatting.
What are you using? Do you have a suggestion (I'm mainly doing Go since 2014, formatting is built into the tooling). Not doing much JS/TS lately.