project-avocado icon indicating copy to clipboard operation
project-avocado copied to clipboard

Search in FAQ crashes

Open Chinmay-KB opened this issue 6 years ago • 3 comments

If for some reason the internet is down while we are searching something in FAQ, app crashes instantly

Steps to reproduce the behaviour:

  1. Go to FAQ
  2. Let the initial list load
  3. Turn off your Mobile data/WiFi
  4. Try searching for something

If we are already into the FAQ section and then net connection is down, then we just exit the FAQ screen. If net is down in the homepage itself, i.e before tapping onto the FAQ card, the whole app crashes and exits

  • Device: Moto G5+
  • OS: PixelOS(Android 9.0 flavour)

Thing to consider here is that FAQ section has been implemented in Native and integrated into Flutter using Platform channel. Checking for internet availability before sending any request should squash the bug

Chinmay-KB avatar Sep 29 '19 13:09 Chinmay-KB

I take care of it! 👍

ferquies avatar Oct 03 '19 18:10 ferquies

Okay, so there are a few places where we need an active internet connection

  1. FAQ
  2. Book your appointment
  3. Mentors

It would be nice if you could check for internet connection everywhere. Also, display an appropriate snackbar notifying the user of the inactive internet connection.

I'd recommend you to rather implement the internet connectivity logic on the flutter side than in native, so that implementing the snackbar is easier for you

Chinmay-KB avatar Oct 04 '19 01:10 Chinmay-KB

Ok, in Mentors section there are actually a button that indicates there is no internet connection. Did you mean we must show the "No internet connection" snackbar before open any section that needs internet or implement the snackbar inside each section? And in case we must show the snackbar inside each screen, in the case of FAQ I have to show it in native.

ferquies avatar Oct 05 '19 10:10 ferquies