BREAKING CHANGE: Corrected the CredentialsType to only be used on CollectorInitiated Subscriptions

[dotps1]

Ok, I know there is a lot of commits here, but I think its all set. Basically I found that if I removed the <CredentialsType> tag in the generated xml, the subscription would create successfully, so I assumed the tag name was wrong (the plural Credentials looks wrong to me). Well, what I think is happening is that wecutil just ignores tags it doesn't know, so changing it from <CredentialsType> to <CredentialType> seemed to fix it. But after further research, even using wecutil cs -? you can see in the example, it is in fact <CredentialsType>. So, with that being said, I restored all the files back to your current dev branch, so things would be back to how it was, and I then just moved the <CredentialsType> tag to only be applied to the generated XML if a CollectionInitiated subscription is created. This seems to fix the issue. I did however still change the TransportPort to default to null, and I added it the Get-TargetRescource function because that property was missing. I also fixed some not functional things to pass the tests that where failing, replacing tabs, and adding new lines at the end of files.

Fixes #9

---

This change is 

[dotps1]

whats up @PowerShellTeam? Is this an abandoned DSC-Resource?

[kwirkykat]

@dotps1 Not abandonned. It just doesn't have an active maintainer. Labelling this as a breaking change as it modifies the default behavior of the resource.

[kwirkykat]

@dotps1 Why did you change the default value of TransportPort to null?

[dotps1]

@kwirkykat i honestly don't remember, i submitted this pull request months ago. And i havent needed to use this DSC Resource in quite sometime.

[johlju]

@dotps1 Sorry it has gone such a long time. Are you able to work on this resource?

Regarding changing port to null, one commit has the following commit message.

"Errors throw when defaulting the TransportPort to 5985, so defaulting to null. Also, the TransportPort was not defined in the Get-TargetResource, so I added that. I also fixed some of the appveyor failed tests."

Would be good to know where the error occurred, running the resource or running the tests?

[johlju]

Review status: 0 of 5 files reviewed at latest revision, 1 unresolved discussion.

---

DSCResources/MSFT_xWEFSubscription/MSFT_xWEFSubscription.psm1, line 176 at r3 (raw file):

<CredentialsType>

In the issue that this solved it says that this should be <CredentialType> (singluar on credential). What should we use here? :thinking:

---

Comments from Reviewable

[stale[bot]]

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.