Pol Dellaiera

Results 439 comments of Pol Dellaiera

@jtojnar heya mate, I am unable to reproduce the issue locally. I can successfully build `php74` and `php80`... I have no clue what is going on there.

Ah indeed, the lower bound of the patch is not set, so it applies to all the version before 8.3... and it breaks the builds. What would be the best...

@jtojnar Let me know what you think, especially commit [0694588](https://github.com/fossar/nix-phps/pull/475/commits/0694588eb4ffc89f59fe419e8727e01cfcf2a920)

Let me test that patch immediately. For later reference, here's how I test this: ```nix system.replaceRuntimeDependencies = let flags = [ "DEBUG=1" "NUM_THREADS=128" ]; flagsToRemove = [ "NUM_THREADS=64" ]; in...

The patch doesn't solve the issue and the backtrace is different now: GDB Session ``` root@nixos /h/pol# nix shell nixpkgs#gdb Welcome to fish, the friendly interactive shell Type help for...

The template is already defined here: https://github.com/loophp/iterators/blob/a0ba41c111f9c3eb09642ad9260cd6753edeb3e0/src/FilterIterableAggregate.php#L12

Mmmh I'm not convinced. Also, I think there's a typo in your snippet. 1. `s/tempalte/template` 2. Why not adding `template T of iterable` at line 12? Have you tried?

This is not supported by PHPStan. ``` ------ ---------------------------------------------------------------------------------------------------------------------- Line FilterIterableAggregate.php ------ ---------------------------------------------------------------------------------------------------------------------- 17 PHPDoc tag @template T for class loophp\iterators\FilterIterableAggregate with bound type iterable is not supported. ------ ----------------------------------------------------------------------------------------------------------------------...

I quickly drafted something, making minor changes here and there, and it seems to work. Among the changes I made in the original algorithm, the biggest change was to remove...