drupal-project icon indicating copy to clipboard operation
drupal-project copied to clipboard

drupal-composer/drupal-project has [not] been deprecated

Open gagarine opened this issue 5 years ago • 13 comments

As of the release of Drupal 8.8.0 - the recommend composer template changed from drupal-composer/drupal-project to the officially supported: drupal/recommended-project

I think this should be indicated in the readme.

gagarine avatar Jan 16 '20 13:01 gagarine

Its not deprecated for me. The official template is in its infancy and I predict it will take years to achieve parity. This template has a batteries-included approach such as built in support for .env files, drush+drupal-console, ...

weitzman avatar Jan 16 '20 13:01 weitzman

Where does this deprecation statement come from?

normanlolx avatar Jan 16 '20 14:01 normanlolx

It come from drupal.org official doc. Perhaps another wording would be more appropriate to reflect this project is still actively developed.

But really I believe having one "official" way help a lot people not familiar with Drupal. So a notice is certainly beneficial.

On Thu, Jan 16, 2020, 15:56 Norman Kämper-Leymann [email protected] wrote:

Where does this deprecation statement come from?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/drupal-composer/drupal-project/pull/550?email_source=notifications&email_token=AABIB2W3E7G3HCPMUQKBQATQ6BYRDA5CNFSM4KHTZM6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJEK65A#issuecomment-575188852, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABIB2RFLTF6MSGR3J4GIP3Q6BYRDANCNFSM4KHTZM6A .

gagarine avatar Jan 16 '20 17:01 gagarine

I can't find anything anywhere stating that this template should be considered deprecated. It even reflects the latest changes when using the core scaffold and core dev meta packages.

Please also have a look at https://github.com/drupal-composer/drupal-project/issues/538

normanlolx avatar Jan 16 '20 17:01 normanlolx

So I guess the situation is not 100% clear and I get confused too (and a lot more will). From https://www.drupal.org/docs/develop/using-composer/using-composer-to-install-drupal-and-manage-dependencies#download-core Screenshot 2020-01-16 at 23 31 57

Do you have a proposition to make the situation clearer in the readme? Agree deprecated is not good (as it still supported) but what about "unofficial"? And explain what kind of extra features it bring?

gagarine avatar Jan 16 '20 22:01 gagarine

So, just a comment about the documentation quoted above:

As of the release of Drupal 8.8.0 - the recommended composer template changed from drupal-composer/drupal-project to the officially supported: drupal/recommended-project

At the time that was written, drupal-composer/drupal-project was still using drupal-composer/drupal-scaffold, which we strongly want to deprecate. Now that drupal-composer/drupal-project is using drupal/core-composer-scaffold, just as drupal/recommended-project is, that message is misleading. We should probably rewrite it to help guide folks to the right path.

Eventually we'll have a conversion tool, which could potentially be smart about looking at what is in the source site and adapting it to use the latest recommended components. Once we're at that point, we'll have a recommended upgrade path that is easy to describe. Right now, it is not super clear.

greg-1-anderson avatar Feb 13 '20 06:02 greg-1-anderson

Composer command line also throws a warning saying this package is deprecated/obsoleted (can't remember which one), and recommends a removal

skyred avatar Feb 13 '20 07:02 skyred

@skyred – Which "this" package are you referring to?

normanlolx avatar Feb 13 '20 07:02 normanlolx

@skyred is perhaps referring to webflo/drupal-dev-dependencies, which was used in older versions of drupal-composer/drupal-project, and is in fact deprecated, no longer maintained, and should be removed. Replace it with drupal/core-dev, as this project has done in the current HEAD of master.

If you are using webflo/drupal-core-strict, replace it with drupal/core-recommended (and also remove drupal/core).

greg-1-anderson avatar Feb 13 '20 17:02 greg-1-anderson

You guys are aware than except the couples of people that build those tools, nobody can understand what's going on and what they should use?

So can we add somethings in the readme? What should we recommend today for someone that want to install and manage Drupal using composer?

I'm proposing something like that:

**Warning**: As of Drupal 8.8.0 the recommended approach (especially for beginners to Composer) is to use the [composer template at drupal/recommended-project](https://www.drupal.org/docs/develop/using-composer/using-composer-to-install-drupal-and-manage-dependencies).

A table that compare the features of the different projects would be great. But this warning should be enough for new user.

gagarine avatar Feb 17 '20 14:02 gagarine

Yes, we are aware that more documentation and more help (e.g. a converter tool) is necessary. Thanks to all who help close these gaps.

greg-1-anderson avatar Feb 17 '20 15:02 greg-1-anderson

Warning: As of Drupal 8.8.0 the recommended approach (especially for beginners to Composer) is to use the composer template at drupal/recommended-project.

I'd suggest that drupal-composer/drupal-project is better for beginners as it has some sane defaults, or "batteries included" as others have suggested.

mstrelan avatar Mar 11 '20 05:03 mstrelan

I can see why Drupal wants to maintain https://github.com/drupal/recommended-project and https://github.com/drupal/legacy-project.

What I can't understand is why they are officially recommended by Drupal. They don't even have a README.

https://github.com/drupal-composer/drupal-project is light years ahead and should be officially recommended in my opinion.

guix77 avatar May 04 '20 06:05 guix77