sqlalchemy-stubs icon indicating copy to clipboard operation
sqlalchemy-stubs copied to clipboard

Add typing to ORM query return value

Open qsantos opened this issue 6 years ago • 4 comments

This obviously does not cover every case, but it is a significant improvement in that it enables typing on the results of most queries.

qsantos avatar Oct 10 '19 16:10 qsantos

Also please note tests are failing (you should probably add an explicit __iter__ override).

ilevkivskyi avatar Oct 14 '19 13:10 ilevkivskyi

  • [x] CLA signed
  • [ ] __iter__ was making something fail during typecheck; I'll see if I can fix it
  • [ ] I'll run the tests of the CI locally to fix the issues with linting/automated testing
  • [x] other issues you raised fixed

Nice CI by the way!

qsantos avatar Oct 14 '19 18:10 qsantos

Thanks for updates! All looks good now, I am just waiting for the test fix.

ilevkivskyi avatar Oct 14 '19 18:10 ilevkivskyi

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 16 '22 21:04 CLAassistant