pb-jelly icon indicating copy to clipboard operation
pb-jelly copied to clipboard

Use criterion instead of unstable libtest for benches

Open j-g00da opened this issue 6 months ago • 2 comments

Resolves #20

j-g00da avatar May 29 '25 15:05 j-g00da

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 29 '25 15:05 CLAassistant

  1. bench.rs moved to benches:

It is not possible to include benchmarks in code in the src/ directory as one might with the regular benchmark harness.

  1. Making pb_test::gen public:

It is not possible to benchmark non-pub functions. External benchmarks, including those using Criterion.rs, are compiled as a separate crate, and non-pub functions are not visible to the benchmarks.

https://bheisler.github.io/criterion.rs/book/user_guide/known_limitations.html

j-g00da avatar May 29 '25 16:05 j-g00da