dropbox-sdk-python icon indicating copy to clipboard operation
dropbox-sdk-python copied to clipboard

abstract method for "requests" has different signature to implementations.

Open papadeltasierra opened this issue 1 year ago • 5 comments

Describe the bug Was attempting to create some good type stubs and got these errors:

Running mypy for Python 3.8...
*** Testing Python 3.8 on linux
Testing third-party packages...
testing dropbox (31 files)... failure (exit code 1)

stubs/dropbox/dropbox/dropbox_client.pyi:70: error: Definition of "request" in base class "_DropboxTransport" is incompatible with definition in base class "DropboxBase"  [misc]
stubs/dropbox/dropbox/dropbox_client.pyi:72: error: Definition of "request" in base class "_DropboxTransport" is incompatible with definition in base class "DropboxTeamBase"  [misc]

Tracked down the to abstract method signatures in DropboxBase and DropTeamBase being different to that in _DropboxTransport.

To Reproduce Follow steps in CONTRIBUTING.md for thetypeshed repository.

Expected Behavior No error above.

Actual Behavior Errors as indicated.

Screenshots N/A

Versions v12.0.2 Python Distributor ID: Ubuntu Description: Ubuntu 22.04.4 LTS Release: 22.04 Codename: jammy

Additional context Solution is probably to make abstract signatures match the implementation in _DropboxTransport.

papadeltasierra avatar Aug 11 '24 16:08 papadeltasierra