dropbox-sdk-js icon indicating copy to clipboard operation
dropbox-sdk-js copied to clipboard

Fix node examples

Open mistermoe opened this issue 7 years ago • 7 comments

The node examples included with this sdk don't work. I've gone ahead and gotten them to a working state. If you all are cool with these changes then i'll go ahead comments within every example along with a README in the node directory with some helpful information.

mistermoe avatar Feb 23 '18 10:02 mistermoe

Thanks for putting this together!

greg-db avatar Feb 23 '18 15:02 greg-db

any updates on this?

MaxDesiatov avatar May 02 '18 14:05 MaxDesiatov

No, I don't have an update on this right now.

greg-db avatar May 02 '18 14:05 greg-db

is there anything in this PR that prevents it from being merged?

MaxDesiatov avatar May 02 '18 14:05 MaxDesiatov

I don't know if there are any currently issues with this pull request. It is awaiting review. We'll update it once it's been reviewed.

greg-db avatar May 02 '18 14:05 greg-db

Hello, thank you for your PR! We would love to include this example. However, we just released a major version that updated a lot of the examples. If you wouldn't mind rebasing and updating, I would love to merge this in.

rogebrd avatar Sep 25 '20 21:09 rogebrd

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 16 '22 21:04 CLAassistant