dropbox-sdk-js icon indicating copy to clipboard operation
dropbox-sdk-js copied to clipboard

fix: crash on node v21 (#1130)

Open coderaiser opened this issue 1 year ago • 2 comments

Fix of an issue from #1130 related to node-fetch and deprecated punycode

image

Checklist

General Contributing

  • [x] Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • [ ] Non-code related change (markdown/git settings etc)
  • [x] SDK Code Change
  • [ ] Example/Test Code Change

Validation

  • [x] Does npm test pass?
  • [x] Does npm run build pass?
  • [x] Does npm run lint pass?

coderaiser avatar Mar 16 '24 16:03 coderaiser

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 16 '24 16:03 CLAassistant

Thanks for submitting this! I'll ask the team to review it.

greg-db avatar Mar 18 '24 18:03 greg-db