AffectedModuleDetector icon indicating copy to clipboard operation
AffectedModuleDetector copied to clipboard

Address Issue #258: Configuration predicate to control dependency graph creation

Open mcumings opened this issue 1 year ago • 2 comments
trafficstars

Adds a new configuration option to allow the consumer to provision of a Predicate<Configuration> instance to customize what Configuration instances should be considered when building the dependency graph.


For your consideration, adding something like this would be very helpful for us. Appreciate the work y'all have done thus far.

Note that the choice of Property<Predicate<Configuration>> was used because:

  • Use of gradle properties allows the value to be changed all the way up until execution, which gets around afterEvaluate issues
  • It exposes the actual Configuration instead of just its name

mcumings avatar Aug 20 '24 21:08 mcumings

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 20 '24 21:08 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 20 '24 21:08 CLAassistant

@joshafeinberg - This PR has been sitting around for over a year now. I just rebased it to the latest HEAD. Any chance I could have you folks take a look at this?

Thanks in advance.

mcumings avatar Sep 15 '25 20:09 mcumings

@joshafeinberg - This PR has been sitting around for over a year now. I just rebased it to the latest HEAD. Any chance I could have you folks take a look at this?

Thanks in advance.

Sorry for the delay, we don't review PRs until the CLA is signed usually which I see you completed a couple days ago. Running against CI and can get this merged if all looks good

joshafeinberg avatar Sep 17 '25 15:09 joshafeinberg

Yeah, I had signed it initially but IIRC I got failures when attempting to submit the CLA. It seems to still be in a bit of a weird state with 2 comments, only one of which indicates that it had been signed. 🤷‍♂️

mcumings avatar Sep 17 '25 18:09 mcumings