Jonathan White

The DatabaseOpenDialog which shows that first window is set to be always on top on Linux: https://github.com/keepassxreboot/keepassxc/blob/develop/src/gui/DatabaseOpenDialog.cpp#L39-L42 The BrowserAccessConfirmDialog is also set to be always on top on all platforms....

It should be the MainWindow, but need to look at where these are being instantiated to figure that out. Based on the Qt docs, if a QDialog has a parent...

Correct it is implicitly `nullptr` if nothing is passed. That might be the difference!

Need to test this one again

Pretty sure we are missing kSecAccessControlOr Our access control settings should be: `kSecAccessControlWatch | kSecAccessControlOr | kSecAccessControlBiometryCurrentSet` I think in its current setup you need to present BOTH the watch...

Will be made for 2.7.2 release

Wait a sec, I am confused, we already have kSecAccessControlOr in the code since the original commit: https://github.com/keepassxreboot/keepassxc/blob/dab6d9408e7e37ec86cf679efd86116994ffd201/src/touchid/TouchID.mm#L102-L105

That makes perfect sense @phoerious see above

I don't think there is in this case because the watch flag api is strongly guarded by a 10.15 minimum on apple's side.

That check was put in to appease the "build on every outdated macos possible" crowd. I'm all on favor of nuking it.