drizzle-orm icon indicating copy to clipboard operation
drizzle-orm copied to clipboard

Published 20 hours ago • verified publisher icon drizzle-team

Fix schema of all SQLite migration tables

Open mlafeldt opened this issue 1 year ago • 5 comments

Based on #2658, but fixes all SQLite migrators.

mlafeldt avatar Sep 12 '24 10:09 mlafeldt

Fixes #2969

melv-n avatar Sep 15 '24 16:09 melv-n

@mirague @mlafeldt I can abandon my PR.

These migrations tables should be created with STRICT. https://www.sqlite.org/stricttables.html

STRICT would have caught this.

Thoughts?

mphill avatar Sep 16 '24 20:09 mphill

STRICT would have caught this.

@mirague That's a good idea, but Drizzle doesn't seem to support adding STRICT yet (?).

So far, we've had 3 PRs fixing the issue, but unfortunately zero interest in reviewing/merging them. 😕

mlafeldt avatar Sep 21 '24 11:09 mlafeldt

Any clue of the process on how to get this merged?

melv-n avatar Sep 21 '24 12:09 melv-n

https://x.com/DrizzleORM/status/1837524772202135675 👍

mlafeldt avatar Sep 21 '24 18:09 mlafeldt

Thanks! I was suffering from the same issue. I'm wating for this commit to be released.

iksflow avatar Oct 18 '24 23:10 iksflow

I'm wating for this commit to be released.

@iksflow So are we. 😃

mlafeldt avatar Oct 19 '24 10:10 mlafeldt

I’m very surprised this hasn’t been merged/fixed after many months. SQLite migrations are pretty broken without this 🤨

melv-n avatar Oct 19 '24 10:10 melv-n

Any chance to get some eyes on fixing sqlite migrations support with drizzle? @AndriiSherman

melv-n avatar Oct 19 '24 10:10 melv-n

Just ran into this too. Another one that will need fixing to this list is the durable-sqlite migrator https://github.com/drizzle-team/drizzle-orm/blob/4d72640a80c8d233cd4a6470b8577917b1a622c3/drizzle-orm/src/durable-sqlite/migrator.ts#L54-L58

jasoncabot avatar Feb 03 '25 15:02 jasoncabot

It's only been 5 months and numerous pings since opening this PR - enough time for the bug to manifest elsewhere. Nice!

(Pardon my snark, but it's the only way I can still deal with this project.)

mlafeldt avatar Feb 03 '25 15:02 mlafeldt

I ran into the issue this PR should address while following the default install for expo https://orm.drizzle.team/docs/get-started/expo-new

dvaldivia avatar Mar 23 '25 05:03 dvaldivia

bump on this, still very important change for sqlite imo

adpadillar avatar Apr 07 '25 17:04 adpadillar

This currently stops my app from doing any migration. Can we get some eyes on this?

Does anyone know of a workaround? I use expo so I kinda rely on the migration scripts.

DeadIine avatar Aug 09 '25 15:08 DeadIine

bump, without this, the sqlite side is impossible.

Oh man, it is officially one year.

RechieKho avatar Sep 23 '25 11:09 RechieKho