node-XMLHttpRequest icon indicating copy to clipboard operation
node-XMLHttpRequest copied to clipboard

#190 fix "Cannot read property 'headers' of undefined"

Open d9k opened this issue 4 years ago • 2 comments

d9k avatar Jul 29 '21 10:07 d9k

This is actually a very important PR. Can someone please review it?

It only has a couple of lines changed, and changed in such a way that it actually reads the response headers instead of a makeshift hack around setting a global headers object.

Not to mention that global variables are substantially more prone to bugs than generated/object instance fields. i.e. var headers should be response.headers and/or get headers() {...}.

D-Pow avatar Nov 07 '21 05:11 D-Pow

Can this get merged in or are no new releases planned?

AlexanderKidd avatar Jul 29 '22 12:07 AlexanderKidd