bevy_pixel_camera icon indicating copy to clipboard operation
bevy_pixel_camera copied to clipboard

Upgrading to bevy `v0.14`

Open porkbrain opened this issue 1 year ago • 7 comments

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to choose either at their option.

porkbrain avatar Jul 05 '24 15:07 porkbrain

I've been using this for a couple of weeks in my project:

[patch.crates-io]
bevy_pixel_camera = { git = "https://github.com/porkbrain/bevy_pixel_camera", rev = "623860527e646776a76c8def559c91e184fba116" }

Haven't had any issues.

ironpeak avatar Jul 24 '24 15:07 ironpeak

I've been using the v0.14 branch rather than the rev id. Also no issues. Hopefully this gets merged in soon

edit: I misread your toml. This is what I've been using (yours is probably better but I don't know what it means)

[dependencies.bevy_pixel_camera]
git = "https://github.com/porkbrain/bevy_pixel_camera"
branch = "bevy-v0.14"

DispairingGoose avatar Jul 24 '24 19:07 DispairingGoose

I've also been using this branch in a project and didn't encounter any issues, although after upgrade to 0.14 my Steamdeck build stopped rendering, even though bevy examples on 0.14 work fine. I will try to run the examples also with the pixel camera plugin to find out whether this plugin could be at fault for broken steamdeck build.

porkbrain avatar Jul 27 '24 09:07 porkbrain

Hopefully this gets merged soon.

While we wait for that, another option is to directly reference this pull request as a dependency :

[dependencies]
#bevy_pixel_camera = "0.13.0"
bevy_pixel_camera = { git = "https://github.com/drakmaniso/bevy_pixel_camera", rev = "refs/pull/37/head" }

mnemotic avatar Aug 07 '24 17:08 mnemotic

I believe one advantage of directly using the commit hash instead of a branch name or a pull request ref is that if my account was compromised (or I became evil) you wouldn't execute malicious code.

porkbrain avatar Oct 19 '24 11:10 porkbrain

It seems that the maintainer, @drakmaniso, doesn't have the availability to maintain the plugin. I tried reaching them also on discord to no avail. Perhaps someone else can try one more time.

I am in process of migrating away from github to sourcehub. I will keep this repository alive to not break your code.

I plan to fork this plugin and republish it under my username as I depend on it in my game. When that happens, I shall inform you here and you can consider migrating. However, the fork will likely live on sourcehub.

porkbrain avatar Oct 19 '24 12:10 porkbrain

I created a fork and published it for my game here: bevy_modern_pixel_camera

Most of the logic is taken from this repository so migrating should be fairly simple.

ironpeak avatar Oct 26 '24 13:10 ironpeak