sysdig icon indicating copy to clipboard operation
sysdig copied to clipboard

eBPF support for RHEL 7.6

Open gianlucaborello opened this issue 6 years ago • 5 comments

The only unfortunate casualty was switching to populating the cgroup subsystem name at compile time rather than runtime, which makes the eBPF state increase significantly. So I removed two more cgroups from the supported list. It can potentially be reworked to account that, but as long as we grab one relevant we should be fully able to do the container detection. It'll probably be worth adding all of them at some point.

gianlucaborello avatar Dec 07 '18 07:12 gianlucaborello

I'm still a eBPF newbie, but FWIW this change looks good to me :)

nathan-b avatar Dec 07 '18 16:12 nathan-b

Thanks for reviewing. I think we can merge this whenever one of the following events will happen:

  1. We need to change some other bpf code: if we do that, we might as well bring in this code, since it's overall a net positive change and especially the PID helpers look much cleaner now than before.
  2. The CI tests are up and running: once we have that, there should be no problem merging code (though I've already tested this by running the tests on several kernels).
  3. Some customers/users want to try it, so we can give it to them.

gianlucaborello avatar Dec 07 '18 16:12 gianlucaborello

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Feb 23 '23 02:02 github-actions[bot]

We still need this one around...I know it's been a while

nathan-b avatar Mar 03 '23 08:03 nathan-b

SonarCloud Quality Gate failed.    Quality Gate failed

Bug D 11 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 5 Security Hotspots
Code Smell D 71 Code Smells

No Coverage information No Coverage information
3.9% 3.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

sonarqubecloud[bot] avatar Sep 05 '23 15:09 sonarqubecloud[bot]