visual-studio-code
visual-studio-code copied to clipboard
dracula
add editorActiveLineNumber.foreground
Thanks for the contribution!
I'm inclined to say we should keep as-is since the yellow could be jarring to some users who have gotten used to the theme in its current form.
I'll keep this open for now to see if it draws any further feedback.
A solution for you in the interim is just to add an override for this to your user settings.
I'd prefer to not add a non-spec color if we chose to try this.
The yellow is a fine idea, but let's wait until the PR has a few more :+1: before giving it a try. Want to make sure this is something everybody would want, rather than just a few people.
Personally I would go with simple white (foreground color). Regardless of what color, I do think that this is an useful addition as it helps you gauge which line you're on even better. Reason my line highlight is so dark is because I had real trouble seeing the active line with vanilla Dracula. Having a highlight in the margin makes sense.
Another comparison, with vanilla theme (no custom modifications, no line highlight):
@dsifford - Adding a comment here to keep this thread active. I'm currently working on the Dracula theme for Nova and am struggling to pick a color for the active line number. When I took over it was a non-spec color so to have an 'official' color would take the guess work out of it.
FWIW - Vim uses yellow for the active line number though that seems to be determined by the editor itself rather than the maintainers.
@bdielman Thanks! Ya we should prob make a decision here. I use vim as my daily driver and I've grown accustomed to yellow, but not opposed to go with majority rule here.