Emiliano 'AlberT' Gabrielli comments

Results 29 comments of


                                            Emiliano 'AlberT' Gabrielli

`terraform_docs`: Check abillity to use native `terraform-docs` config as replacement for custom `--hook-config=`

I'm using the following hook configuration and everything related to terraform-doc is managed by the config files. It works like a charm but all the hook-config args (which are necessary...

Ignore `.git` folder by default

I think using `ignore-from-file .gitignore` it's a better solution for the specific case. I normally ignore dot-files here and then add exceptions for those being committed

fix: Change count for for_each on ram_principal_association due resource recreation

Maybe an approach could be to write a local module for the association and then use for_each to instantiate many instances of the module?

fix: Change count for for_each on ram_principal_association due resource recreation

Any chance to have this done? (keep alive)

fix: Change count for for_each on ram_principal_association due resource recreation

@ebarros29 @bryantbiggs is this MR destined to be closed?

fix: Change count for for_each on ram_principal_association due resource recreation

> Sorry guys, It has been busy days since my last comment 😫 > > Actually I don't know if it's worth to go ahead with this PR, since we...

Trigger a CloseAccount API when an account request is deleted

Pay attention! Double check what is the right workflow to correctly [decommission an AFT created account](https://docs.aws.amazon.com/controltower/latest/userguide/aft-remove-account.html). You must then un-enroll it from CT. And finally close it (account email would...

No expiration set on any CloudWatch LogGroup

I have to admit that I have missed this, sorry. Anyway, the description states it controls only the lambda related groups and, if I'm not wrong again, there should be...

No expiration set on any CloudWatch LogGroup

Hi @stumins, I can confirm that the parameter fixes my issue (I also already upgraded to 1.8.0) and acts both on lambda and codecommit log groups. Anyway, it looks like...