Douglas Wilson
Douglas Wilson
Fixing this would require a major version bump, sadly :(
@timaschew , I'm unsure what the major version of this module has to do with the version of Express.
Hi @HarshithaKP I have never heard of the issue you are describing. Can you provide code and steps to reproduce the issue you are referring to?
> Anything landing in 4.x should be additive or fixes until 5. This change may actually be breaking, even though it seems like it wouldn't. Eg. someone might have a...
The reason I only _suggested_ it wait for 5 is because there is a bunch of work around it. If it were to change, it should be made configurable. Of...
Also, feel free to read through all the git commits in the history, at least through all the ones over the past couple months. They demonstrate that back-compat pattern well,...
> So would the ideal approach I already highlighted the ideal approach in the comment below what you quoted :)
@tunniclm, we should focus on getting the needed changed into Express 5.0 instead of adding more weird back-compat solutions. There are already two solutions for Express 4.x users can use...
Hi @tunniclm, I was hoping the labels would make it clear which mode these issues correspond to :) This is for the `finalhandler` module and it's already been implemented: https://github.com/pillarjs/finalhandler/commit/0a6847daeaa534df8aeaa7bb3e7d39568648a0a7
Sorry, wrong commit; I'll have to take a look later, but yea, this is against the `finalhandler` module.