Douglas Wilson
Douglas Wilson
So yes, it sucks that Node.js 8 introduced a bug, though obviously they should own up to it and fix the bug. Just reading the docs for the interface seems...
Yea, I was mostly wondering what the implementation differences between those two modules in Node.js core are. I assume that URLSearchParams is not usable by this module, otherwise I'm sure...
And in case it wasn't clear: the issue you highlighted in the queryparser is absolutely a bug; a space at the end of a value should not prevent decoding the...
Thanks for the information, @TimothyGu ! Can you explain what the differences are between the classes? Is `URLSearchParams` just a drop-in replacement for the `querystring` module or are there other...
And for anyone coming across this issue, if you would like to take a stab at whatever it would take to use `URLSearchParams` when available, and `querystring` otherwise, please feel...
And for those looking (trying to put together urlencoded issues here), it would be great if we have to move parsers (like to `URLSearchParams` from `querystring`), it should either support...
Ok, so for those following along looking to make a PR, it sounds from @TimothyGu above that you cannot just drop in the `URLSearchParam` class depending on Node.js version without...
Re the charsets, gotcha. The idea, though, is that the charset support is at least consistent across all our body parsers. I assume that the ICU could be plugged into...
Tanks, @TimothyGu very helpful! Re one of my questions above, it was about the following quote in that PR: > By default, with small-icu, only the UTF-8, UTF-16le and UTF-16be...
/cc @crandmck