sg3_utils icon indicating copy to clipboard operation
sg3_utils copied to clipboard

sg_vpd_vendor: Fix missing newline in the svpd_decode_vendor() error path

Open tbzatek opened this issue 3 years ago • 2 comments
trafficstars

This fixes the output of sg_vpd trying to fetch VPD pages and reporting failure:

...
SCSI Ports VPD page:
  Relative port=1
    Target port descriptor(s):
      designator type: NAA,  code set: Binary
       transport: Serial Attached SCSI Protocol (SPL-4)
        0x3222222000003e7e
  Relative port=2
    Target port descriptor(s):
      designator type: NAA,  code set: Binary
       transport: Serial Attached SCSI Protocol (SPL-4)
        0x3222222000003e7f

Vendor VPD page=0xc0  failed to fetchVendor VPD page=0xc1  failed to fetchVendor VPD page=0xc2  failed to fetchVendor VPD page=0xc3  failed to fetchVendor VPD page=0xc4  failed to fetchVendor VPD page=0xc5  failed to fetchVendor VPD page=0xc8  failed to fetchVendor VPD page=0xc9  failed to fetchVendor VPD page=0xca  failed to fetchVendor VPD page=0xd0  failed to fetchVendor VPD page=0xd1  failed to fetchVendor VPD page=0xd2  failed to fetch[root@localhost ~]# 

tbzatek avatar Jun 08 '22 14:06 tbzatek

Applied upstream. Will appear when the next subversion revision is pushed to this github mirror. Thanks. BTW Starting to add JSON support. Starting small, so far with sg_opcodes and sg_rep_zones. Try the --json[=JO] option.

doug-gilbert avatar Jun 08 '22 17:06 doug-gilbert

Oh nice, thanks!

tbzatek avatar Jun 09 '22 14:06 tbzatek