Patrick Double

Results 48 comments of Patrick Double

> Be good to add tests. `refreshScope()` is only called when the view is initialized. I didn't see anything that would mock that in `SessionUnitTest`. Ideas?

It looks like the only way to verify `refreshScope()` is called is to check for side effects in the site tree unless the method is made package-private. How do you...

> It looks like the only way to verify `refreshScope()` is called is to check for side effects in the site tree unless the method is made package-private. How do...

> Regarding the duplication, that should not be needed as `testGui` should have visibility into `test` (if not that should be changed rather than duplicate). As far as I can...

The requests used by paramdigger are missing a lot of headers from the original request. Original request: ``` GET http://manager.htb/search.html HTTP/1.1 host: manager.htb User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101...

When using the context menu on a request to attack using paramdigger, it seems reasonable for the user to expect the attack requests will look as much like the original...

> To address the DCO requirement you'll need to sign-off the commit(s): > > * https://github.com/zaproxy/zaproxy/blob/main/CONTRIBUTING.md#developer-certificate-of-origin > > * https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---signoff > > > Note there’s also a code scanning result...

I have read the CLA Document and I hereby sign the CLA recheck

I have read the CLA Document and I hereby sign the CLA