EasyCaching icon indicating copy to clipboard operation
EasyCaching copied to clipboard

Published 20 hours ago • verified publisher icon dotnetcore

This Async Implementation is fake

Open luizcarlosfaria opened this issue 3 years ago • 1 comments

On source code https://github.com/dotnetcore/EasyCaching/blob/bc4a0177cf2cc9c220afbee6aafc6065770af239/bus/EasyCaching.Bus.RabbitMQ/DefaultRabbitMQBus.cs#L113

ExchangeDeclare is a blocking and painful operation, run entire publish as a task, sounds less fake .

luizcarlosfaria avatar Jun 14 '22 10:06 luizcarlosfaria

@luizcarlosfaria Thanks for your interest in this project.

Yes, this is a fake implementation.

The main considerations are as follows

  1. It seems that the RabbitMQ client don't have async BasicPublish
  2. Both Publish/PublishAsync of IEasyCachingBus should be implemented or we should throw NotImplementedException?

catcherwong avatar Jun 14 '22 14:06 catcherwong