wpf
wpf copied to clipboard
dotnet
Hyphen based ligatures don't work in WPF
See https://github.com/tonsky/FiraCode/issues/259 for the full issue description.
Would be good to get this fixed for .NET Core 3.
This makes Visual Studio very sad. -> is a very common symbol in C++, and I don't get pretty arrows for it.
I've tracked this bug through various different platforms now, and it would be really great if it could get fixed. It's a small thing, but it would make everyone's programming life a little more fun.
I suspect there's something wrong in TextItemizer that it breaks out hyphens (-) as individual run.
I understand this originally was probably by design, but considering that hyphen based ligatures are a desired feature in some fonts, that original "by design" is not appropriate anymore and needs to be revisited. I would have contributed by researching the implementation and proposing a fix, but considering the text engine is going to stay closed source this really needs to be done by MS.
~Windows Terminal, VS Code and JetBrains all render the text better than Visual Studio, which uses the WPF renderer. Text rendered by WPF is less crisp than other technologies; horizontal lines are thinner, and vertical lines are thicker.~
~I heard that WPF used by Visual Studio uses ~2010 version of DWrite, and there was no demand to update the version of WPF used in .NET Framework. I would like this comment to serve as proof of demand for a fix on behalf of Visual Studio Editor's users and developers.~
~Some of the user feedback: https://www.reddit.com/r/VisualStudio/comments/ev5b2u/is_there_an_editor_text_readability_fix_already/ https://developercommunity.visualstudio.com/content/problem/44061/some-programming-ligatures-do-not-work.html https://developercommunity.visualstudio.com/content/problem/899361/editor-readability.html?childToView=904574#comment-904574~
Just to be clear, the last two comments are off-topic and have nothing to do with hyphen-based ligatures (which is what this issue is about). The text layouting is unrelated to the font rendering.
Thanks for clarification @weltkante. I thought that setting layout and rendering are handled in the same piece of code. I will move my comments to #2025
#2025 has received some fix and this issue is still open because its not fixed yet. Not sure what exactly you mean?
Given Visual Studio .Net Core is open source.. is it possible to get into the source code and find and fix the bug for them and submit a pull request? Particularly if it's a WPF bug, seems like it might be possible.
Neither Visual Studio is open source, nor the part of WPF that does text processing. I already mentioned this above, Microsoft has to fix this bug, the community cannot help.
Any progress ？
Obviously not. WPF might be open source but repo got owned by WinUI team and they don't know much about C# or WPF. For new features only chance is a community pull request. And the last pull request which added a new feature was ignored for months, then closed without merging.
Any progress ？
Obviously not. WPF might be open source but repo got owned by WinUI team and they don't know much about C# or WPF. For new features only chance is a community pull request. And the last pull request which added a new feature was ignored for months, then closed without merging.
thank u for your reply. there is no hope . ms does not care about it.
I've mentioned it in VS2022 YouTube Chat, and they reacted to the comment: https://www.youtube.com/watch?v=lsInDJdx6As
I've mentioned it in VS2022 YouTube Chat, and they reacted to the comment: https://www.youtube.com/watch?v=lsInDJdx6As
Its at 22:14 btw for the benefit of everyone
Status update, this is still an issue. Is there any plan to fix this issue?
See tonsky/FiraCode#259 for the full issue description.
Would be good to get this fixed for .NET Core 3.
.NET 6 released...
Can you please fix this? Its been on the bug list for years (literaly).
What's so special about hyphens anyways?
They take part in word breaking / line wrapping so probably have special code handling them that didn't have ligatures in mind when being written. Unfortunately its in a closed source blob thats linked into WPF, so I can just guess.
Would be good to get this fixed for .NET Core 3.
3 years later, .NET 7 is on the horizon and this remains unfixed.
See tonsky/FiraCode#259 for the full issue description.
Would be good to get this fixed for .NET Core 3.
I am not sure wether it is fixed or not in .NET Core 3, but Visual Studio seems to use .Net Framework 4.8?
