spark icon indicating copy to clipboard operation
spark copied to clipboard

Fixes #1078: update: newtonsoft.json package reference version

Open cutecycle opened this issue 3 years ago • 3 comments

We are excited to review your PR.

So we can do the best job, please check:

  • [x] There's a descriptive title that will make sense to other developers some time from now.
  • [x] There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • [x] Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • [x] You have included any necessary tests in the same PR.

Changes

Fixes #1078

  • Update csproj to the latest Newtonsoft.Json.

cutecycle avatar Jun 27 '22 14:06 cutecycle

I'm not sure how to request review from a PR that started as a draft... @Niharikadutta ?

cutecycle avatar Jun 30 '22 16:06 cutecycle

@suhsteve can you also review please?

Niharikadutta avatar Jul 14 '22 21:07 Niharikadutta

linking description since I don't have issue link permission: https://github.com/dotnet/spark/issues/1078

cutecycle avatar Jul 14 '22 21:07 cutecycle

LGTM, thanks @cutecycle !

AFFogarty avatar Oct 24 '22 22:10 AFFogarty