runtime Faster "obj is T[]" for sealed T

trafficstars

Let's see if my assumptions were correct. Closes https://github.com/dotnet/runtime/issues/75815

// isinst
bool IsArrayOfStrings(object o) => o is string[];

// castclass
void CastToArrayOfString(IEnumerable<string> e) => Consume((string[])e);


[MethodImpl(MethodImplOptions.NoInlining)]
void Consume(string[] str) { }

codegen diff: https://www.diffchecker.com/IoRePQ7d

jit-diffs (409 methods affected)

PMI CodeSize Diffs for System.Private.CoreLib.dll, framework assemblies for  default jit

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 64751433
Total bytes of diff: 64754979
Total bytes of delta: 3546 (0.01 % of base)
Total relative delta: 11.82
    diff is a regression.
    relative diff is a regression.


Top file regressions (bytes):
         751 : ILCompiler.Reflection.ReadyToRun.dasm (0.33% of base)
         719 : FSharp.Core.dasm (0.02% of base)
         568 : System.Data.Common.dasm (0.03% of base)
         423 : System.Memory.dasm (0.15% of base)
         187 : System.Private.DataContractSerialization.dasm (0.02% of base)
         179 : System.Private.CoreLib.dasm (0.00% of base)
         131 : System.ComponentModel.Composition.dasm (0.04% of base)
         108 : System.Collections.dasm (0.02% of base)
          86 : System.DirectoryServices.AccountManagement.dasm (0.02% of base)
          69 : Microsoft.CSharp.dasm (0.02% of base)
          69 : System.Net.Http.dasm (0.01% of base)
          55 : System.Management.dasm (0.01% of base)
          53 : System.Diagnostics.PerformanceCounter.dasm (0.05% of base)
          41 : System.Net.WebSockets.Client.dasm (0.18% of base)
          39 : Microsoft.VisualBasic.Core.dasm (0.01% of base)
          38 : System.Diagnostics.Process.dasm (0.03% of base)
          33 : Microsoft.DotNet.XUnitExtensions.dasm (0.14% of base)
          31 : Newtonsoft.Json.dasm (0.00% of base)
          28 : System.Diagnostics.EventLog.dasm (0.02% of base)
          20 : System.Reflection.Context.dasm (0.04% of base)

Top file improvements (bytes):
         -86 : System.Collections.Concurrent.dasm (-0.02% of base)
         -48 : System.Private.Xml.dasm (-0.00% of base)
         -30 : xunit.execution.dotnet.dasm (-0.01% of base)
         -18 : System.Linq.dasm (-0.00% of base)
         -16 : Microsoft.Extensions.Primitives.dasm (-0.06% of base)
         -13 : Microsoft.Diagnostics.FastSerialization.dasm (-0.01% of base)
          -5 : System.DirectoryServices.Protocols.dasm (-0.00% of base)

39 total files with Code Size differences (7 improved, 32 regressed), 235 unchanged.

Top method regressions (bytes):
          71 ( 6.05% of base) : ILCompiler.Reflection.ReadyToRun.dasm - Internal.Pgo.PgoProcessor:<Merge>g__MergeInSchemaElem|9_0[System.Nullable`1[int],System.Nullable`1[int]](System.Collections.Generic.Dictionary`2[Internal.Pgo.PgoSchemaElem,Internal.Pgo.PgoSchemaElem],Internal.Pgo.PgoSchemaElem)
          67 ( 5.85% of base) : ILCompiler.Reflection.ReadyToRun.dasm - Internal.Pgo.PgoProcessor:<Merge>g__MergeInSchemaElem|9_0[ubyte,System.Nullable`1[int]](System.Collections.Generic.Dictionary`2[Internal.Pgo.PgoSchemaElem,Internal.Pgo.PgoSchemaElem],Internal.Pgo.PgoSchemaElem)
          66 ( 5.75% of base) : ILCompiler.Reflection.ReadyToRun.dasm - Internal.Pgo.PgoProcessor:<Merge>g__MergeInSchemaElem|9_0[long,System.Nullable`1[int]](System.Collections.Generic.Dictionary`2[Internal.Pgo.PgoSchemaElem,Internal.Pgo.PgoSchemaElem],Internal.Pgo.PgoSchemaElem)
          63 ( 5.48% of base) : ILCompiler.Reflection.ReadyToRun.dasm - Internal.Pgo.PgoProcessor:<Merge>g__MergeInSchemaElem|9_0[short,System.Nullable`1[int]](System.Collections.Generic.Dictionary`2[Internal.Pgo.PgoSchemaElem,Internal.Pgo.PgoSchemaElem],Internal.Pgo.PgoSchemaElem)
          61 ( 1.84% of base) : System.Management.dasm - System.Management.ManagementClassGenerator:ProcessPropertyQualifiers(System.Management.PropertyData,byref,byref,byref,bool,byref):System.String:this
          54 ( 4.54% of base) : ILCompiler.Reflection.ReadyToRun.dasm - Internal.Pgo.PgoProcessor:<Merge>g__MergeInSchemaElem|9_0[System.Numerics.Vector`1[float],System.Nullable`1[int]](System.Collections.Generic.Dictionary`2[Internal.Pgo.PgoSchemaElem,Internal.Pgo.PgoSchemaElem],Internal.Pgo.PgoSchemaElem)
          51 ( 7.98% of base) : FSharp.Core.dasm - Microsoft.FSharp.Primitives.Basics.Seq:tryLastV[System.Numerics.Vector`1[float]](System.Collections.Generic.IEnumerable`1[System.Numerics.Vector`1[float]]):Microsoft.FSharp.Core.FSharpValueOption`1[System.Numerics.Vector`1[float]]
          51 ( 1.63% of base) : System.Management.dasm - System.Management.PropertyData:MapValueToWmiValue(System.Object,byref,byref):System.Object
          46 ( 4.54% of base) : System.Collections.dasm - System.Collections.Generic.LinkedList`1[System.Numerics.Vector`1[float]]:OnDeserialization(System.Object):this
          45 ( 3.46% of base) : ILCompiler.Reflection.ReadyToRun.dasm - Internal.Pgo.PgoProcessor:EncodePgoData[System.Nullable`1[int],System.Nullable`1[int]](System.Collections.Generic.IEnumerable`1[Internal.Pgo.PgoSchemaElem],Internal.Pgo.IPgoEncodedValueEmitter`2[System.Nullable`1[int],System.Nullable`1[int]],bool)
          45 ( 6.46% of base) : FSharp.Core.dasm - Microsoft.FSharp.Primitives.Basics.Seq:tryLastV[System.Nullable`1[int]](System.Collections.Generic.IEnumerable`1[System.Nullable`1[int]]):Microsoft.FSharp.Core.FSharpValueOption`1[System.Nullable`1[int]]
          41 ( 3.58% of base) : ILCompiler.Reflection.ReadyToRun.dasm - Internal.Pgo.PgoProcessor:<Merge>g__MergeInSchemaElem|9_0[int,System.Nullable`1[int]](System.Collections.Generic.Dictionary`2[Internal.Pgo.PgoSchemaElem,Internal.Pgo.PgoSchemaElem],Internal.Pgo.PgoSchemaElem)
          38 ( 3.11% of base) : System.Diagnostics.Process.dasm - System.Diagnostics.PerformanceCounterLib:GetStringTable(bool):System.Collections.Generic.Dictionary`2[int,System.String]:this
          38 ( 2.72% of base) : System.Diagnostics.PerformanceCounter.dasm - System.Diagnostics.PerformanceCounterLib:GetStringTable(bool):System.Collections.Hashtable:this
          36 ( 7.79% of base) : FSharp.Core.dasm - Microsoft.FSharp.Core.CompilerServices.ArrayCollector`1[System.Nullable`1[int]]:AddMany(System.Collections.Generic.IEnumerable`1[System.Nullable`1[int]]):this
          36 ( 6.96% of base) : FSharp.Core.dasm - Microsoft.FSharp.Core.CompilerServices.ArrayCollector`1[System.Numerics.Vector`1[float]]:AddMany(System.Collections.Generic.IEnumerable`1[System.Numerics.Vector`1[float]]):this
          36 ( 2.57% of base) : System.Memory.dasm - System.Buffers.ReadOnlySequenceDebugView`1[System.Nullable`1[int]]:.ctor(System.Buffers.ReadOnlySequence`1[System.Nullable`1[int]]):this
          36 ( 2.57% of base) : System.Memory.dasm - System.Buffers.ReadOnlySequenceDebugView`1[System.Numerics.Vector`1[float]]:.ctor(System.Buffers.ReadOnlySequence`1[System.Numerics.Vector`1[float]]):this
          35 ( 2.09% of base) : ILCompiler.Reflection.ReadyToRun.dasm - <ParsePgoData>d__6`2[System.Numerics.Vector`1[float],System.Nullable`1[int]]:MoveNext():bool:this
          34 ( 2.06% of base) : ILCompiler.Reflection.ReadyToRun.dasm - <ParsePgoData>d__6`2[System.Nullable`1[int],System.Nullable`1[int]]:MoveNext():bool:this

Top method improvements (bytes):
        -260 (-9.24% of base) : System.Private.Xml.dasm - System.Xml.Serialization.XmlSchemaImporter:ImportChoiceGroup(System.Xml.Schema.XmlSchemaGroupBase,System.String,System.Xml.Serialization.CodeIdentifiers,System.Xml.Serialization.CodeIdentifiers,System.Xml.Serialization.INameScope,System.String,bool,byref,bool):System.Xml.Serialization.MemberMapping:this
         -85 (-5.34% of base) : System.Private.Xml.dasm - System.Xml.Serialization.XmlSchemaImporter:ImportTypeMembers(System.Xml.Schema.XmlSchemaType,System.String,System.String,System.Xml.Serialization.CodeIdentifiers,System.Xml.Serialization.CodeIdentifiers,System.Xml.Serialization.INameScope,byref,bool,bool):System.Xml.Serialization.MemberMapping[]:this
         -64 (-4.78% of base) : System.Management.dasm - System.Management.QualifierData:MapQualValueToWmiValue(System.Object):System.Object
         -25 (-37.88% of base) : System.Net.Http.dasm - System.Net.Http.Headers.HttpHeaders:GetEntriesArray():System.Net.Http.Headers.HeaderEntry[]:this
         -22 (-18.33% of base) : Microsoft.Extensions.Primitives.dasm - Microsoft.Extensions.Primitives.StringValues:IsNullOrEmpty(Microsoft.Extensions.Primitives.StringValues):bool
         -19 (-2.18% of base) : System.Net.Http.dasm - System.Net.Http.MultipartContent:SerializeHeadersToStream(System.IO.Stream,System.Net.Http.HttpContent,bool):this
         -15 (-28.85% of base) : FSharp.Core.dasm - Microsoft.FSharp.Core.ExtraTopLevelOperators:getArray[System.Nullable`1[int]](System.Collections.Generic.IEnumerable`1[System.Nullable`1[int]]):System.Nullable`1[int][]
         -15 (-28.85% of base) : FSharp.Core.dasm - Microsoft.FSharp.Core.ExtraTopLevelOperators:getArray[System.Numerics.Vector`1[float]](System.Collections.Generic.IEnumerable`1[System.Numerics.Vector`1[float]]):System.Numerics.Vector`1[float][]
         -15 (-28.85% of base) : System.ComponentModel.Composition.dasm - Microsoft.Internal.Collections.CollectionServices:AsArray[System.Nullable`1[int]](System.Collections.Generic.IEnumerable`1[System.Nullable`1[int]]):System.Nullable`1[int][]
         -15 (-28.85% of base) : System.ComponentModel.Composition.dasm - Microsoft.Internal.Collections.CollectionServices:AsArray[System.Numerics.Vector`1[float]](System.Collections.Generic.IEnumerable`1[System.Numerics.Vector`1[float]]):System.Numerics.Vector`1[float][]
         -15 (-28.85% of base) : xunit.execution.dotnet.dasm - Xunit.Sdk.CollectionExtensions:CastOrToArray[System.Nullable`1[int]](System.Collections.Generic.IEnumerable`1[System.Nullable`1[int]]):System.Nullable`1[int][]
         -15 (-28.85% of base) : xunit.execution.dotnet.dasm - Xunit.Sdk.CollectionExtensions:CastOrToArray[System.Numerics.Vector`1[float]](System.Collections.Generic.IEnumerable`1[System.Numerics.Vector`1[float]]):System.Numerics.Vector`1[float][]
         -12 (-0.38% of base) : System.Private.Xml.dasm - System.Xml.Serialization.XmlSerializationReader:ReadArray(System.String,System.String):System.Object:this
         -10 (-1.44% of base) : System.Collections.Concurrent.dasm - System.Collections.Concurrent.ConcurrentDictionary`2[double,System.Nullable`1[int]]:System.Collections.ICollection.CopyTo(System.Array,int):this
         -10 (-1.44% of base) : System.Collections.Concurrent.dasm - System.Collections.Concurrent.ConcurrentDictionary`2[int,System.Nullable`1[int]]:System.Collections.ICollection.CopyTo(System.Array,int):this
         -10 (-1.44% of base) : System.Collections.Concurrent.dasm - System.Collections.Concurrent.ConcurrentDictionary`2[long,System.Nullable`1[int]]:System.Collections.ICollection.CopyTo(System.Array,int):this
         -10 (-1.44% of base) : System.Collections.Concurrent.dasm - System.Collections.Concurrent.ConcurrentDictionary`2[short,System.Nullable`1[int]]:System.Collections.ICollection.CopyTo(System.Array,int):this
         -10 (-1.44% of base) : System.Collections.Concurrent.dasm - System.Collections.Concurrent.ConcurrentDictionary`2[System.Nullable`1[int],System.Nullable`1[int]]:System.Collections.ICollection.CopyTo(System.Array,int):this
         -10 (-1.44% of base) : System.Collections.Concurrent.dasm - System.Collections.Concurrent.ConcurrentDictionary`2[System.Numerics.Vector`1[float],System.Nullable`1[int]]:System.Collections.ICollection.CopyTo(System.Array,int):this
         -10 (-1.44% of base) : System.Collections.Concurrent.dasm - System.Collections.Concurrent.ConcurrentDictionary`2[ubyte,System.Nullable`1[int]]:System.Collections.ICollection.CopyTo(System.Array,int):this

Top method regressions (percentages):
          13 (29.55% of base) : System.Diagnostics.EventLog.dasm - System.Diagnostics.Eventing.Reader.EventLogConfiguration:get_ProviderNames():System.Collections.Generic.IEnumerable`1[System.String]:this
          15 (29.41% of base) : System.Private.Xml.dasm - <>c__DisplayClass57_0:<WriteAttribute>b__1(System.Object):System.String:this
          12 (27.91% of base) : System.Data.Common.dasm - System.Data.Common.SqlBinaryStorage:SetStorage(System.Object,System.Collections.BitArray):this
          12 (27.91% of base) : System.Data.Common.dasm - System.Data.Common.SqlBooleanStorage:SetStorage(System.Object,System.Collections.BitArray):this
          12 (27.91% of base) : System.Data.Common.dasm - System.Data.Common.SqlBytesStorage:SetStorage(System.Object,System.Collections.BitArray):this
          12 (27.91% of base) : System.Data.Common.dasm - System.Data.Common.SqlByteStorage:SetStorage(System.Object,System.Collections.BitArray):this
          12 (27.91% of base) : System.Data.Common.dasm - System.Data.Common.SqlCharsStorage:SetStorage(System.Object,System.Collections.BitArray):this
          12 (27.91% of base) : System.Data.Common.dasm - System.Data.Common.SqlDateTimeStorage:SetStorage(System.Object,System.Collections.BitArray):this
          12 (27.91% of base) : System.Data.Common.dasm - System.Data.Common.SqlDecimalStorage:SetStorage(System.Object,System.Collections.BitArray):this
          12 (27.91% of base) : System.Data.Common.dasm - System.Data.Common.SqlDoubleStorage:SetStorage(System.Object,System.Collections.BitArray):this
          12 (27.91% of base) : System.Data.Common.dasm - System.Data.Common.SqlGuidStorage:SetStorage(System.Object,System.Collections.BitArray):this
          12 (27.91% of base) : System.Data.Common.dasm - System.Data.Common.SqlInt16Storage:SetStorage(System.Object,System.Collections.BitArray):this
          12 (27.91% of base) : System.Data.Common.dasm - System.Data.Common.SqlInt32Storage:SetStorage(System.Object,System.Collections.BitArray):this
          12 (27.91% of base) : System.Data.Common.dasm - System.Data.Common.SqlInt64Storage:SetStorage(System.Object,System.Collections.BitArray):this
          12 (27.91% of base) : System.Data.Common.dasm - System.Data.Common.SqlMoneyStorage:SetStorage(System.Object,System.Collections.BitArray):this
          12 (27.91% of base) : System.Data.Common.dasm - System.Data.Common.SqlSingleStorage:SetStorage(System.Object,System.Collections.BitArray):this
          12 (27.91% of base) : System.Data.Common.dasm - System.Data.Common.SqlStringStorage:SetStorage(System.Object,System.Collections.BitArray):this
          12 (27.91% of base) : System.Data.Common.dasm - System.Data.Common.StringStorage:SetStorage(System.Object,System.Collections.BitArray):this
          31 (24.80% of base) : System.Private.DataContractSerialization.dasm - <>c__41`1[System.Nullable`1[int]]:<GetCollectionSetItemDelegate>b__41_0(System.Object,System.Object,int):System.Object:this
          13 (24.53% of base) : Microsoft.CodeAnalysis.CSharp.dasm - Microsoft.CodeAnalysis.CSharp.EnumExtensions:GetValues[System.Numerics.Vector`1[float]]():System.Numerics.Vector`1[float][]

Top method improvements (percentages):
         -25 (-37.88% of base) : System.Net.Http.dasm - System.Net.Http.Headers.HttpHeaders:GetEntriesArray():System.Net.Http.Headers.HeaderEntry[]:this
         -15 (-28.85% of base) : FSharp.Core.dasm - Microsoft.FSharp.Core.ExtraTopLevelOperators:getArray[System.Nullable`1[int]](System.Collections.Generic.IEnumerable`1[System.Nullable`1[int]]):System.Nullable`1[int][]
         -15 (-28.85% of base) : FSharp.Core.dasm - Microsoft.FSharp.Core.ExtraTopLevelOperators:getArray[System.Numerics.Vector`1[float]](System.Collections.Generic.IEnumerable`1[System.Numerics.Vector`1[float]]):System.Numerics.Vector`1[float][]
         -15 (-28.85% of base) : System.ComponentModel.Composition.dasm - Microsoft.Internal.Collections.CollectionServices:AsArray[System.Nullable`1[int]](System.Collections.Generic.IEnumerable`1[System.Nullable`1[int]]):System.Nullable`1[int][]
         -15 (-28.85% of base) : System.ComponentModel.Composition.dasm - Microsoft.Internal.Collections.CollectionServices:AsArray[System.Numerics.Vector`1[float]](System.Collections.Generic.IEnumerable`1[System.Numerics.Vector`1[float]]):System.Numerics.Vector`1[float][]
         -15 (-28.85% of base) : xunit.execution.dotnet.dasm - Xunit.Sdk.CollectionExtensions:CastOrToArray[System.Nullable`1[int]](System.Collections.Generic.IEnumerable`1[System.Nullable`1[int]]):System.Nullable`1[int][]
         -15 (-28.85% of base) : xunit.execution.dotnet.dasm - Xunit.Sdk.CollectionExtensions:CastOrToArray[System.Numerics.Vector`1[float]](System.Collections.Generic.IEnumerable`1[System.Numerics.Vector`1[float]]):System.Numerics.Vector`1[float][]
         -22 (-18.33% of base) : Microsoft.Extensions.Primitives.dasm - Microsoft.Extensions.Primitives.StringValues:IsNullOrEmpty(Microsoft.Extensions.Primitives.StringValues):bool
        -260 (-9.24% of base) : System.Private.Xml.dasm - System.Xml.Serialization.XmlSchemaImporter:ImportChoiceGroup(System.Xml.Schema.XmlSchemaGroupBase,System.String,System.Xml.Serialization.CodeIdentifiers,System.Xml.Serialization.CodeIdentifiers,System.Xml.Serialization.INameScope,System.String,bool,byref,bool):System.Xml.Serialization.MemberMapping:this
         -85 (-5.34% of base) : System.Private.Xml.dasm - System.Xml.Serialization.XmlSchemaImporter:ImportTypeMembers(System.Xml.Schema.XmlSchemaType,System.String,System.String,System.Xml.Serialization.CodeIdentifiers,System.Xml.Serialization.CodeIdentifiers,System.Xml.Serialization.INameScope,byref,bool,bool):System.Xml.Serialization.MemberMapping[]:this
          -2 (-5.26% of base) : System.Net.Http.dasm - System.Net.Http.Headers.HttpHeaders:get_EntriesAreLiveView():bool:this
          -5 (-4.95% of base) : System.Net.Http.dasm - Enumerator:.ctor(System.Object):this
          -5 (-4.90% of base) : System.Net.Http.dasm - System.Net.Http.Headers.HeaderStringValues:GetEnumerator():Enumerator:this
         -64 (-4.78% of base) : System.Management.dasm - System.Management.QualifierData:MapQualValueToWmiValue(System.Object):System.Object
          -7 (-3.93% of base) : System.Private.CoreLib.dasm - System.Collections.Concurrent.ConcurrentQueue`1[System.Nullable`1[int]]:System.Collections.ICollection.CopyTo(System.Array,int):this
          -7 (-3.93% of base) : System.Private.CoreLib.dasm - System.Collections.Concurrent.ConcurrentQueue`1[System.Numerics.Vector`1[float]]:System.Collections.ICollection.CopyTo(System.Array,int):this
          -6 (-3.64% of base) : System.Threading.Tasks.Dataflow.dasm - System.Threading.Tasks.Dataflow.TransformManyBlock`2[double,System.Nullable`1[int]]:StoreOutputItems(System.Collections.Generic.KeyValuePair`2[double,long],System.Collections.Generic.IEnumerable`1[System.Nullable`1[int]]):this
          -6 (-3.64% of base) : System.Threading.Tasks.Dataflow.dasm - System.Threading.Tasks.Dataflow.TransformManyBlock`2[int,System.Nullable`1[int]]:StoreOutputItems(System.Collections.Generic.KeyValuePair`2[int,long],System.Collections.Generic.IEnumerable`1[System.Nullable`1[int]]):this
          -6 (-3.64% of base) : System.Threading.Tasks.Dataflow.dasm - System.Threading.Tasks.Dataflow.TransformManyBlock`2[long,System.Nullable`1[int]]:StoreOutputItems(System.Collections.Generic.KeyValuePair`2[long,long],System.Collections.Generic.IEnumerable`1[System.Nullable`1[int]]):this
          -6 (-3.64% of base) : System.Threading.Tasks.Dataflow.dasm - System.Threading.Tasks.Dataflow.TransformManyBlock`2[short,System.Nullable`1[int]]:StoreOutputItems(System.Collections.Generic.KeyValuePair`2[short,long],System.Collections.Generic.IEnumerable`1[System.Nullable`1[int]]):this

409 total methods with Code Size differences (106 improved, 303 regressed), 391066 unchanged.

Mostly size regression coming from castclass expansion which is expected.

Sep 19 '22 00:09 EgorBo

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch See info in area-owners.md if you want to be subscribed.

Issue Details

Let's see if my assumptions were correct. Closes https://github.com/dotnet/runtime/issues/75815

bool IsArrayOfStrings(object o) => o is string[]; // or e.g. IEnumerable<string> is string[]

codegen:

Author:	EgorBo
Assignees:	-
Labels:	`area-CodeGen-coreclr`
Milestone:	-

Sep 19 '22 00:09 ghost

🚀Finally!

Sep 19 '22 04:09 omariom

Relaxed checks made NativeAOT unhappy, let me see why

Sep 19 '22 14:09 EgorBo

Failed test: nativeaot_SmokeTests::_DynamicGenerics_DynamicGenerics_DynamicGenerics_cmd (nativeaot\\SmokeTests\\DynamicGenerics\\DynamicGenerics\\DynamicGenerics.cmd)
Unhandled Exception: EETypeRva:0x00496880(System.Diagnostics.DebugProvider+DebugAssertException): IsInstanceOfClass called with parameterized MethodTable
   at System.Diagnostics.DebugProvider.Fail(String, String) + 0x36
   at System.Diagnostics.Debug.Fail(String, String) + 0x21
   at System.Runtime.TypeCast.IsInstanceOfClass(MethodTable*, Object) + 0x48
   at System.Runtime.TypeCast.CheckCastClass(MethodTable*, Object) + 0x15
   at B282745.testMDArrayWith3Dimensions() + 0x2e8
   at CoreFXTestLibrary.Internal.Runner.RunTestMethod(TestInfo) + 0x195
   at CoreFXTestLibrary.Internal.Runner.RunTest(TestInfo) + 0x21
   at CoreFXTestLibrary.Internal.Runner.RunTests(TestInfo[], String[]) + 0x6d
   at EntryPointMain.Main(String[]) + 0x2416
   at DynamicGenerics!<BaseAddress>+0x3055ab

Perhaps this optimization is not valid for NativeAOT for MD arrays?

Sep 19 '22 14:09 EgorBo

The optimization is valid for NativeAOT.

The problem seems to be that the codegen is violating the JIT helper contract. NativeAOT asserts. CoreCLR has a test hole (note that this is nativeaot smoke test that does not run on CoreCLR), or it happens to work and not crash, but it does not make it right.

Sep 19 '22 14:09 jkotas

The optimization is valid for NativeAOT.

The problem seems to be that the codegen is violating the JIT helper contract. NativeAOT asserts. CoreCLR has a test hole (note that this is nativeaot smoke test that does not run on CoreCLR), or it happens to work and not crash, but it does not make it right.

hm.. I don't see an API to find out whether a type is IsParameterizedType/IsDefType/IsTypeNodeShareable (e.g. via getClassAttrs) Also, I use compareTypesForEquality(elementCls, elementCls) == TypeCompareState::Must to filter out shared types but apparently it passed for NativeAOT for shared type

Sep 19 '22 16:09 EgorBo

hm.. I don't see an API to find out whether a type is IsParameterizedType/IsDefType/IsTypeNodeShareable (e.g. via getClassAttrs)

I am not sure why you would need this. I think you just need to overwriting the helper to CORINFO_HELP_CHKCASTCLASS_SPECIAL when we are dealing with array casts here: https://github.com/dotnet/runtime/blob/4cd3e780c469e2416b6ebaba903dbea7c411a5b8/src/coreclr/jit/importer.cpp#L12535

Sep 19 '22 20:09 jkotas

@jkotas thanks for suggestion, the code is cleaner now! @dotnet/jit-contrib PTAL

Sep 20 '22 13:09 EgorBo

Hm something is off on CI - with Git fetch

Sep 20 '22 17:09 EgorBo

Improvements on Arm64: https://github.com/dotnet/perf-autofiling-issues/issues/8663 Improvements and Regressions: https://github.com/dotnet/perf-autofiling-issues/issues/8662

Sep 22 '22 16:09 DrewScoggins

runtime runtime copied to clipboard

Faster "obj is T[]" for sealed T

runtime
runtime copied to clipboard