runtime
runtime copied to clipboard
dotnet
74642 change isostorage path
The path of a file created by IsolatedStorageFile.GetUserStoreForApplication() changes between Xamarin.iOS and .NET 6, and also changes between different builds of the application under .NET 6.
Switched back to the .isolatedstorage approach we had in legacy mono https://github.com/mono/mono/blob/main/mcs/class/corlib/System.IO.IsolatedStorage/IsolatedStorageFile.cs#L304-L327
Fix #74642
Tagging subscribers to this area: @dotnet/area-system-io See info in area-owners.md if you want to be subscribed.
Issue Details
null
| Author: | mkhamoyan |
|---|---|
| Assignees: | - |
| Labels: |
|
| Milestone: | - |
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
I'm imagining something like two different applications that just so happen to store their own version of a file
file.txtand that the IdentityHash helps distinguish the files so that they wouldn't be unwantedly modified by a different app. If this is the case, then it seems like a bug for iOS that should be fixed (since it was stated that the hash stays the same on Android).
On disk, each app has it's own directory, so I'm not concerned about collisions between different apps.
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3137018195
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@mkhamoyan, I am looking at runtime outerloop failures. Have you checked the test failures in
Runtime-extra-platforms tests
- System.Collections.Immutable.Tests.WorkItemExecution
- System.Formats.Tar.Tests.WorkItemExecution
- System.Net.Http.Functional.Tests.WorkItemExecution
@mkhamoyan, I am looking at runtime outerloop failures. Have you checked the test failures in
This PR doesn't appear to have anything to do with the suites you listed. Are they tvOS failures? If so, can you provide a link to where you are looking? I believe they may be known intermittent issues with devices and not problems with tests.