runtime icon indicating copy to clipboard operation
runtime copied to clipboard

[wasm] Use source built emsdk packages for the runtime build

Open steveisok opened this issue 1 year ago • 10 comments

This change moves away from using upstream emsdk to our source built packages as part of the wasm build.

steveisok avatar Mar 26 '24 01:03 steveisok

@akoeplinger I hand edited the eng/Version.xml/props. Do we have to do anything w/ darc to help resolve what's failing?

steveisok avatar Mar 26 '24 01:03 steveisok

It was just a typo :)

I'm wondering though whether we need to add one of these source-build .Intermediate dependencies too?

akoeplinger avatar Mar 26 '24 07:03 akoeplinger

I want to start using the packages asap but I don't think we want to use individual props for each item here when the package name needs to change whenever we do an emsdk bump.

lewing avatar Mar 27 '24 03:03 lewing

I want to start using the packages asap but I don't think we want to use individual props for each item here when the package name needs to change whenever we do an emsdk bump.

Change the package name out of emsdk then?

steveisok avatar Mar 27 '24 15:03 steveisok

@akoeplinger the browser offsets build is consistently failing, but actually works local. There shouldn't be any difference, but apparently there is. Can you look and see if you spot anything?

steveisok avatar Apr 02 '24 23:04 steveisok

Looks like it can't find emcmake?

bash: line 1: emcmake: command not found

akoeplinger avatar Apr 04 '24 14:04 akoeplinger

Looks like it can't find emcmake?

bash: line 1: emcmake: command not found

Yeah, local windows it's fine. I'm confused why CI is having trouble. Inspecting the binlog, provision seems to do its job and the source build emsdk artifacts are in the right place.

steveisok avatar Apr 04 '24 15:04 steveisok

I can reproduce the failure using the mcr.microsoft.com/dotnet-buildtools/prereqs:cbl-mariner-2.0-webassembly docker container locally and ./build.sh -subset mono.aotcross -c release -arch wasm -os linux /p:MonoGenerateOffsetsOSGroups=browser

akoeplinger avatar Apr 04 '24 22:04 akoeplinger

I can reproduce the failure using the mcr.microsoft.com/dotnet-buildtools/prereqs:cbl-mariner-2.0-webassembly docker container locally and ./build.sh -subset mono.aotcross -c release -arch wasm -os linux /p:MonoGenerateOffsetsOSGroups=browser

Weird - I have an ubuntu instance locally and it's fine. Hard to imagine why it would be different on mariner?

steveisok avatar Apr 05 '24 04:04 steveisok

Can you please try removing eng/pipelines/mono/update-machine-certs.ps1 and the step in global-build-job.yml that calls it? I think it should no longer be needed with this PR.

akoeplinger avatar Apr 12 '24 07:04 akoeplinger