roslyn
roslyn copied to clipboard
Fix primary ctor param in static context
Fixes #74327
Two cases are skipped because of another bug in the recommender, as noted in the skip reason. The Skip property is also not respected by the test runner, so the tests are commented out.
CC @CyrusNajmabadi
I can't reproduce the failing tests, could I be missing something?
Assert.All() Failure: 1 out of 2 items in the collection did not pass.
[0]: Item: x
Xunit.Sdk.ContainsException: Assert.Contains() Failure
Not found: x
In value: WhereSelectListIterator<CompletionItem, String> ["async", "await", "base", "Base", "bool", ...]
at Xunit.Assert.Contains[T](T expected, IEnumerable1 collection, IEqualityComparer1 comparer) in C:Dev\xunit\xunitsrc\xunit.assertAssertsCollectionAsserts.cs:line 108
at Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense.TestState._Closure$__45-0.Lambda$__0(String v) in //src/EditorFeatures/TestUtilities2/Intellisense/TestState.vb:line 396
at Xunit.Assert.All[T](IEnumerable1 collection, Action1 action) in C:Dev\xunit\xunitsrc\xunit.assertAssertsCollectionAsserts.cs:line 36
When I execute them locally they all pass
@CyrusNajmabadi suggestions in place ptal
@CyrusNajmabadi ready for review with resolved comments
lgtm thanks.