roslyn icon indicating copy to clipboard operation
roslyn copied to clipboard

Fix primary ctor param in static context

Open Rekkonnect opened this issue 1 year ago • 4 comments

Fixes #74327

Two cases are skipped because of another bug in the recommender, as noted in the skip reason. The Skip property is also not respected by the test runner, so the tests are commented out.

CC @CyrusNajmabadi

Rekkonnect avatar Jul 28 '24 11:07 Rekkonnect

I can't reproduce the failing tests, could I be missing something?

Rekkonnect avatar Jul 28 '24 20:07 Rekkonnect

Assert.All() Failure: 1 out of 2 items in the collection did not pass.
[0]: Item: x
Xunit.Sdk.ContainsException: Assert.Contains() Failure
Not found: x
In value:  WhereSelectListIterator<CompletionItem, String> ["async", "await", "base", "Base", "bool", ...]
at Xunit.Assert.Contains[T](T expected, IEnumerable1 collection, IEqualityComparer1 comparer) in C:Dev\xunit\xunitsrc\xunit.assertAssertsCollectionAsserts.cs:line 108
at Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense.TestState._Closure$__45-0.Lambda$__0(String v) in //src/EditorFeatures/TestUtilities2/Intellisense/TestState.vb:line 396
at Xunit.Assert.All[T](IEnumerable1 collection, Action1 action) in C:Dev\xunit\xunitsrc\xunit.assertAssertsCollectionAsserts.cs:line 36

CyrusNajmabadi avatar Jul 28 '24 22:07 CyrusNajmabadi

When I execute them locally they all pass

Rekkonnect avatar Jul 28 '24 22:07 Rekkonnect

@CyrusNajmabadi suggestions in place ptal

Rekkonnect avatar Oct 19 '24 08:10 Rekkonnect

@CyrusNajmabadi ready for review with resolved comments

Rekkonnect avatar Dec 03 '24 23:12 Rekkonnect

lgtm thanks.

CyrusNajmabadi avatar Dec 15 '24 00:12 CyrusNajmabadi