project-system icon indicating copy to clipboard operation
project-system copied to clipboard

Publish updated NuGet packages to NuGet.org

Open jp2masa opened this issue 7 years ago • 14 comments

On NuGet, the latest version of Microsoft.VisualStudio.ProjectSystem.Managed and Microsoft.VisualStudio.ProjectSystem.Managed.VS were published 7 months ago. I couldn't find any myget feed with those packages either. What's the correct way of extending the managed project systems?

jp2masa avatar Jan 18 '18 21:01 jp2masa

@lifengl?

Pilchie avatar Jan 18 '18 21:01 Pilchie

Oh, wait - those are our packages, not the CPS ones :)

Pilchie avatar Jan 18 '18 21:01 Pilchie

They are published to https://dotnet.myget.org/feed/roslyn/package/nuget/Microsoft.VisualStudio.ProjectSystem.Managed, not sure why we haven't pushed them to NuGet.org, but I'll see.

Pilchie avatar Jan 18 '18 21:01 Pilchie

@jmarolf @natidea @genlu Do you know why these haven't been published more recently?

Pilchie avatar Jan 19 '18 16:01 Pilchie

I believe the problem is we never set up a process to track publishing them regularly after balaji left.

jmarolf avatar Jan 19 '18 17:01 jmarolf

This thread has more information about prerelease dependencies that are preventing us from publishing on nuget.org

natidea avatar Jan 19 '18 19:01 natidea

The myget packages have some dependencies that shouldn't be there I think, like RoslynTools.RepoToolset and Microsoft.Net.Compilers, these should have PrivateAssets="All". It would be nice if there were stable packages on NuGet, but I understand that it's not really easy, so I can use the myget packages for now.

jp2masa avatar Jan 19 '18 22:01 jp2masa

This issue will be for discussing/deciding if publishing our packages to NuGet.org on a regular basis actually provides any benefit to anyone. At this point in time, I don't know who would consume those packages from that source. We currently publish to 1 public AzDO feed and 1 internal AzDO feed.

  • Public: https://dev.azure.com/azure-public/vside/_artifacts/feed/vs-impl
  • Internal: https://dev.azure.com/DevDiv/DevDiv/_artifacts/feed/VS

MiYanni avatar Jul 27 '22 20:07 MiYanni

Maybe we should publish packages to NuGet.org for this specific versions of VS.

ocallesp avatar Aug 19 '22 23:08 ocallesp

@ocallesp I think the issue is determining exactly which commit of ours is in those builds. We're not synched enough on our schedule to have a 'release' build of our 'product' that goes into VS. We just keep putting PRs in until the VS release has been cut; even still adding PRs in M2 mode, for example.

MiYanni avatar Aug 22 '22 19:08 MiYanni

I would recommend against additionally publishing to nuget. If someone external does want to reference, they can just use the ADO feed.

adamint avatar Sep 06 '22 18:09 adamint

Perhaps we should unlist all packages from NuGet.org, and make sure the ADO feed is easily discoverable from our readme, if it isn't already.

drewnoakes avatar Sep 07 '22 19:09 drewnoakes

@drewnoakes Yeah, that's what I was thinking too. The main problem is having very old packages on NuGet that people are still downloading. 20+ downloads a day of those old packages is pretty crazy.

https://www.nuget.org/packages/Microsoft.VisualStudio.ProjectSystem.Managed image

https://www.nuget.org/packages/Microsoft.VisualStudio.ProjectSystem.Managed.VS image

MiYanni avatar Sep 07 '22 20:09 MiYanni

Unlisting them won't break those existing users thankfully.

drewnoakes avatar Sep 07 '22 21:09 drewnoakes

We have these available in a public feed already, so we don't need to have them on NuGet.

  • [ ] Update the README.md to specify where these can be found
  • [ ] Unlist the old packages on nuget.org

tmeschter avatar Sep 22 '22 23:09 tmeschter

Additionally, changes here may want to respond to the discussion here: https://github.com/dotnet/project-system/issues/7010

MiYanni avatar Jan 05 '23 00:01 MiYanni

but some people have issues getting the previews from the Azure feed. So the better solution is to release (maybe also preview) versions on nuget which all users get.

MagicAndre1981 avatar Jan 17 '23 20:01 MagicAndre1981

Closing in favour of https://github.com/dotnet/project-system/issues/7010

drewnoakes avatar Apr 13 '23 23:04 drewnoakes