maui icon indicating copy to clipboard operation
maui copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

[net7.0] Update dependencies from xamarin/xamarin-android

Open dotnet-maestro[bot] opened this issue 3 years ago • 16 comments

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency attribute were produced in a build used as input to the parent dependency's build. See Dependency Description Format

  • Coherency Updates:
    • Microsoft.Dotnet.Sdk.Internal: from 7.0.100-rc.2.22477.20 to 7.0.100-rtm.22513.13 (parent: Microsoft.Android.Sdk.Windows)
    • Microsoft.NETCore.App.Ref: from 7.0.0-rc.2.22472.3 to 7.0.0-rtm.22511.4 (parent: Microsoft.Android.Sdk.Windows)
    • Microsoft.NET.Workload.Emscripten.net6.Manifest-7.0.100: from 7.0.0-rc.2.22465.1 to 7.0.0-rtm.22504.3 (parent: Microsoft.NETCore.App.Ref)
    • Microsoft.NETCore.App.Ref: from 7.0.0-rc.2.22472.3 to 7.0.0-rtm.22511.4 (parent: Microsoft.Android.Sdk.Windows)
    • Microsoft.NET.Workload.Emscripten.net7.Manifest-7.0.100: from 7.0.0-rc.2.22465.1 to 7.0.0-rtm.22504.3 (parent: Microsoft.NETCore.App.Ref)

From https://github.com/xamarin/xamarin-android

  • Subscription: 32c82615-b126-403a-5097-08da86083637
  • Build: 7.0.1xx-04fe9838ab79392b219e20ba689445cea16d0e74-1
  • Date Produced: October 14, 2022 10:49:53 PM UTC
  • Commit: 04fe9838ab79392b219e20ba689445cea16d0e74
  • Branch: refs/heads/release/7.0.1xx

dotnet-maestro[bot] avatar Sep 07 '22 13:09 dotnet-maestro[bot]

@mattleibow @rookiejava how do we fix this?

D:\a\_work\1\s\src\DotNet\Dependencies\Workloads.csproj : error NU1101: Unable to find package Samsung.NET.Sdk.Tizen.Manifest-7.0.100-rc.2. No packages exist with this id in source(s): darc-pub-dotnet-runtime-531f715, dotnet-eng, dotnet-public, dotnet6, dotnet7, skiasharp, skiasharp-stable-sha-signed, wasdk-internal [D:\a\_work\1\s\src\DotNet\DotNet.csproj]

rmarinho avatar Sep 08 '22 13:09 rmarinho

@mattleibow @rookiejava how do we fix this?

D:\a\_work\1\s\src\DotNet\Dependencies\Workloads.csproj : error NU1101: Unable to find package Samsung.NET.Sdk.Tizen.Manifest-7.0.100-rc.2. No packages exist with this id in source(s): darc-pub-dotnet-runtime-531f715, dotnet-eng, dotnet-public, dotnet6, dotnet7, skiasharp, skiasharp-stable-sha-signed, wasdk-internal [D:\a\_work\1\s\src\DotNet\DotNet.csproj]

Oh, we will update 7.0.100-rc.2 soon and ping you.

rookiejava avatar Sep 08 '22 13:09 rookiejava

/azp run

rmarinho avatar Sep 08 '22 14:09 rmarinho

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Sep 08 '22 14:09 azure-pipelines[bot]

@rmarinho It seems that rc2 package hasn't been mirrored dotnet-public repo yet. https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet-public

You can build after checking this first. 😉

rookiejava avatar Sep 08 '22 14:09 rookiejava

Ready to build!

rookiejava avatar Sep 08 '22 15:09 rookiejava

/azp run

rmarinho avatar Sep 08 '22 15:09 rmarinho

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Sep 08 '22 15:09 azure-pipelines[bot]

Hum ..

D:\a\_work\1\s\src\DotNet\Dependencies\Workloads.csproj : error NU1101: Unable to find package Samsung.NET.Sdk.Tizen.Manifest-7.0.100-rc.2. No packages exist with this id in source(s): darc-pub-dotnet-runtime-531f715, dotnet-eng, dotnet-public, dotnet6, dotnet7, skiasharp, skiasharp-stable-sha-signed, wasdk-internal [D:\a\_work\1\s\src\DotNet\DotNet.csproj]

rmarinho avatar Sep 08 '22 15:09 rmarinho

/azp run

rmarinho avatar Sep 08 '22 15:09 rmarinho

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Sep 08 '22 15:09 azure-pipelines[bot]

uhmmm.. I don't know the cause, but MacCatalyst, iOS, tvOS, macOS seems to have the similar error.

D:\a\_work\1\s\src\DotNet\Dependencies\Workloads.csproj : error NU1102: Unable to find package Microsoft.NET.Sdk.MacCatalyst.Manifest-7.0.100-rc.2 with version (= 15.4.1024-rc.1) [D:\a\_work\1\s\src\DotNet\DotNet.csproj]

rookiejava avatar Sep 08 '22 16:09 rookiejava

@mattleibow do we normally get the Tizen packages added to dotnet-public?

Workload installation failed: samsung.tizen.sdk::7.0.100-rc.2.24 is not found in NuGet feeds [https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7/nuget/v3/index.json;https://pkgs.dev.azure.com/xamarin/public/_packaging/SkiaSharp/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-runtime-531f715f/nuget/v3/index.json".](https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7/nuget/v3/index.json;https://pkgs.dev.azure.com/xamarin/public/_packaging/SkiaSharp/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-runtime-531f715f/nuget/v3/index.json%22.)
/Users/builder/azdo/_work/2/s/src/DotNet/DotNet.csproj(170,5): error MSB3073: The command ""/Users/builder/azdo/_work/2/s/bin/dotnet/dotnet" workload install tizen --skip-manifest-update --verbosity diag --temp-dir "/Users/builder/azdo/_work/2/s/bin/temp/" --configfile "/Users/builder/azdo/_work/2/s/NuGet.config"" exited with code 1.

jonathanpeppers avatar Sep 09 '22 17:09 jonathanpeppers

@rolfbjarne I ignored CA1416, and updated to latest xamarin-macios builds.

This is now hitting:

/Users/builder/azdo/_work/3/s/bin/dotnet/packs/Microsoft.MacCatalyst.Sdk/15.4.1153-rc.2/targets/Xamarin.Shared.Sdk.targets(371,3): error : Unable to merge the file 'Contents/Resources/Assets.car', it's different between the input app bundles. [/Users/builder/azdo/_work/3/s/src/Controls/samples/Controls.Sample.Sandbox/Maui.Controls.Sample.Sandbox.csproj::TargetFramework=net7.0-maccatalyst]
/Users/builder/azdo/_work/3/s/bin/dotnet/packs/Microsoft.MacCatalyst.Sdk/15.4.1153-rc.2/targets/Xamarin.Shared.Sdk.targets(371,3): error : App bundle file #1: /Users/builder/azdo/_work/3/s/src/Controls/samples/Controls.Sample.Sandbox/bin/Release/net7.0-maccatalyst/maccatalyst-x64/Maui.Controls.Sample.Sandbox.app/Contents/Resources/Assets.car [/Users/builder/azdo/_work/3/s/src/Controls/samples/Controls.Sample.Sandbox/Maui.Controls.Sample.Sandbox.csproj::TargetFramework=net7.0-maccatalyst]
/Users/builder/azdo/_work/3/s/bin/dotnet/packs/Microsoft.MacCatalyst.Sdk/15.4.1153-rc.2/targets/Xamarin.Shared.Sdk.targets(371,3): error : App bundle file #2: /Users/builder/azdo/_work/3/s/src/Controls/samples/Controls.Sample.Sandbox/bin/Release/net7.0-maccatalyst/maccatalyst-arm64/Maui.Controls.Sample.Sandbox.app/Contents/Resources/Assets.car [/Users/builder/azdo/_work/3/s/src/Controls/samples/Controls.Sample.Sandbox/Maui.Controls.Sample.Sandbox.csproj::TargetFramework=net7.0-maccatalyst]

Here is a log: Microsoft.Maui.Samples-Release-Build-dotnet.binlog.zip

jonathanpeppers avatar Sep 13 '22 16:09 jonathanpeppers

@rolfbjarne I ignored CA1416, and updated to latest xamarin-macios builds.

This is now hitting:

/Users/builder/azdo/_work/3/s/bin/dotnet/packs/Microsoft.MacCatalyst.Sdk/15.4.1153-rc.2/targets/Xamarin.Shared.Sdk.targets(371,3): error : Unable to merge the file 'Contents/Resources/Assets.car', it's different between the input app bundles. [/Users/builder/azdo/_work/3/s/src/Controls/samples/Controls.Sample.Sandbox/Maui.Controls.Sample.Sandbox.csproj::TargetFramework=net7.0-maccatalyst]
/Users/builder/azdo/_work/3/s/bin/dotnet/packs/Microsoft.MacCatalyst.Sdk/15.4.1153-rc.2/targets/Xamarin.Shared.Sdk.targets(371,3): error : App bundle file #1: /Users/builder/azdo/_work/3/s/src/Controls/samples/Controls.Sample.Sandbox/bin/Release/net7.0-maccatalyst/maccatalyst-x64/Maui.Controls.Sample.Sandbox.app/Contents/Resources/Assets.car [/Users/builder/azdo/_work/3/s/src/Controls/samples/Controls.Sample.Sandbox/Maui.Controls.Sample.Sandbox.csproj::TargetFramework=net7.0-maccatalyst]
/Users/builder/azdo/_work/3/s/bin/dotnet/packs/Microsoft.MacCatalyst.Sdk/15.4.1153-rc.2/targets/Xamarin.Shared.Sdk.targets(371,3): error : App bundle file #2: /Users/builder/azdo/_work/3/s/src/Controls/samples/Controls.Sample.Sandbox/bin/Release/net7.0-maccatalyst/maccatalyst-arm64/Maui.Controls.Sample.Sandbox.app/Contents/Resources/Assets.car [/Users/builder/azdo/_work/3/s/src/Controls/samples/Controls.Sample.Sandbox/Maui.Controls.Sample.Sandbox.csproj::TargetFramework=net7.0-maccatalyst]

Here is a log: Microsoft.Maui.Samples-Release-Build-dotnet.binlog.zip

So this is a bad interaction between our targets and the resizetizer.

For image assets in universal apps this is what happens:

  1. We compile the image assets in the outer (multi-rid) build, and store a list of the compiled assets in a file.
  2. In each inner (single-rid) build, we load the stored list of already compiled assets, and don't compile those.

Now the resizetizer injects image assets like this:

  1. We compile the image assets in the outer build.
  2. We prodcess the list of already compiled-assets in the inner build.
  3. The resizetizer does its work and adds image assets to the (inner) build.
  4. We compile those newly added assets twice, once per RID.
  5. And then when we try to merge those two outputs into a single app bundle, we fail because the compiled image assets are different.

My guess is that it's enough to add _RemoveProcessedImageAssets before _BeforeCoreCompileImageAssets in these two places:

https://github.com/dotnet/maui/blob/e3f8bd4cc2b44a3e14395ed8461f13ae49a95065/.nuspec/Microsoft.Maui.Resizetizer.targets#L126 https://github.com/dotnet/maui/blob/e3f8bd4cc2b44a3e14395ed8461f13ae49a95065/.nuspec/Microsoft.Maui.Resizetizer.targets#L136

rolfbjarne avatar Sep 15 '22 13:09 rolfbjarne

@rolfbjarne I don't think that fix for Resizetizer helped, here is an new log:

maui_DotNet_net7_0-Release-Build-dotnet.zip

The other issue on this one is:

D:\a\_work\1\s\bin\dotnet\packs\Microsoft.MacCatalyst.Sdk\15.4.1153-rc.2\targets\Xamarin.Shared.Sdk.targets(758,3): error MSB4018: The "Xamarin.MacDev.Tasks.ILStrip" task failed unexpectedly. [D:\a\_work\1\s\src\Controls\samples\Controls.Sample\Maui.Controls.Sample.csproj::TargetFramework=net7.0-maccatalyst]
D:\a\_work\1\s\bin\dotnet\packs\Microsoft.MacCatalyst.Sdk\15.4.1153-rc.2\targets\Xamarin.Shared.Sdk.targets(758,3): error MSB4018: System.ArgumentException: 'Assemblies' is required. (Parameter 'Assemblies') [D:\a\_work\1\s\src\Controls\samples\Controls.Sample\Maui.Controls.Sample.csproj::TargetFramework=net7.0-maccatalyst]
D:\a\_work\1\s\bin\dotnet\packs\Microsoft.MacCatalyst.Sdk\15.4.1153-rc.2\targets\Xamarin.Shared.Sdk.targets(758,3): error MSB4018:    at ILStrip.Execute() [D:\a\_work\1\s\src\Controls\samples\Controls.Sample\Maui.Controls.Sample.csproj::TargetFramework=net7.0-maccatalyst]
D:\a\_work\1\s\bin\dotnet\packs\Microsoft.MacCatalyst.Sdk\15.4.1153-rc.2\targets\Xamarin.Shared.Sdk.targets(758,3): error MSB4018:    at ILStripTasks.ILStripBase.Execute() in /Users/builder/azdo/_work/1/s/xamarin-macios/msbuild/Xamarin.iOS.Tasks/Tasks/ILStripBase.cs:line 18 [D:\a\_work\1\s\src\Controls\samples\Controls.Sample\Maui.Controls.Sample.csproj::TargetFramework=net7.0-maccatalyst]
D:\a\_work\1\s\bin\dotnet\packs\Microsoft.MacCatalyst.Sdk\15.4.1153-rc.2\targets\Xamarin.Shared.Sdk.targets(758,3): error MSB4018:    at Xamarin.MacDev.Tasks.ILStrip.Execute() in /Users/builder/azdo/_work/1/s/xamarin-macios/msbuild/Xamarin.iOS.Tasks/Tasks/ILStrip.cs:line 16 [D:\a\_work\1\s\src\Controls\samples\Controls.Sample\Maui.Controls.Sample.csproj::TargetFramework=net7.0-maccatalyst]
D:\a\_work\1\s\bin\dotnet\packs\Microsoft.MacCatalyst.Sdk\15.4.1153-rc.2\targets\Xamarin.Shared.Sdk.targets(758,3): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [D:\a\_work\1\s\src\Controls\samples\Controls.Sample\Maui.Controls.Sample.csproj::TargetFramework=net7.0-maccatalyst]
D:\a\_work\1\s\bin\dotnet\packs\Microsoft.MacCatalyst.Sdk\15.4.1153-rc.2\targets\Xamarin.Shared.Sdk.targets(758,3): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [D:\a\_work\1\s\src\Controls\samples\Controls.Sample\Maui.Controls.Sample.csproj::TargetFramework=net7.0-maccatalyst]

I think this one only happens on Windows. The log is too big to share the log here, I'll share it in Teams.

jonathanpeppers avatar Sep 15 '22 19:09 jonathanpeppers

@dependabot rebase

rmarinho avatar Oct 17 '22 15:10 rmarinho