maui icon indicating copy to clipboard operation
maui copied to clipboard

1100-Enhancement-DatePicker-supports-nullable-(Selected)-Date

Open ryanwmitchell opened this issue 3 years ago • 2 comments
trafficstars

Description of Change

Implements #

Additions made

  • Adds

PR Checklist

  • [ ] Targets the correct branch
  • [ ] Tests are passing (or failures are unrelated)
  • [ ] Targets a single property for a single control (or intertwined few properties)
  • [ ] Adds the property to the appropriate interface
  • [ ] Avoids any changes not essential to the handler property
  • [ ] Adds the mapping to the PropertyMapper in the handler
  • [ ] Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • [ ] Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • [ ] Tags ported renderer methods with [PortHandler]
  • [ ] Adds an example of the property to the sample project (MainPage)
  • [ ] Adds the property to the stub class
  • [ ] Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • [ ] Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • [ ] APIs that modify focusability?
  • [ ] APIs that modify any text property on a control?
  • [ ] Does this PR modify view nesting or view arrangement in anyway?
  • [ ] Is there the smallest possibility that your PR will change accessibility?
  • [ ] I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

ryanwmitchell avatar Aug 28 '22 20:08 ryanwmitchell

Hey there @ryanwmitchell! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

ghost avatar Aug 28 '22 20:08 ghost

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

:x: ryanwmitchell sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

dnfadmin avatar Aug 28 '22 20:08 dnfadmin

Hey @ryanwmitchell thank you so much for doing this and sorry we didn't get to this earlier. I'm on this now!

Are you still interested in taking this home? If so, let's work on it! If not, also fine, then I will take over and see if we can get it in a mergeable state. Thanks!

jfversluis avatar Feb 17 '23 12:02 jfversluis

No response and PR grew too stale to be recoverable at this point. Let's close it and revisit later. Thanks for the time and effort here!

jfversluis avatar Mar 08 '23 18:03 jfversluis

@jfversluis this is a much need thing on MAUI. A Nullable DatePicker is a must have for a lot of scenarios. Please raise a priority on it.

eder-careplus avatar Jun 08 '23 23:06 eder-careplus