maui
maui copied to clipboard
[Android] Fix ImageButton Padding the third
Description of Change
Improve the workaround (#22298) for the iffy Android ShapeImageView contentPadding/padding handling. The underlying problem is that ShapeImageView updates Padding in onMeasure leading to a double padding. The previous workaround reset the Padding after one eventloop hoping that onMeasure was called in the meantime. This worked for most cases but not all. The "improved" workaround overrides onMeasure and resets the Padding as soon as it was set.
I ran all ImageButton tests I could find and they are all green. So thats a good sign.
Issues Fixed
Fixes #25201 Fixes #16713 Fixes #18001 Fixes #13101
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
Not sure if the test failure are because of this PR. They all fail with a System.TimeoutException.
/rebase
Azure Pipelines successfully started running 3 pipeline(s).
Any chance to get this in for the next release? Both Border and Padding on ImageButton are still broken, with no known workaround. This seems like pretty basic functionality to just straight up not work at all.
This PR also resolves the issue https://github.com/dotnet/maui/issues/18875
We can do Java in a new PR: https://github.com/dotnet/maui/issues/28532