Picker in ListView works on Windows but not on Android

[NanthiniMahalingam]

Root cause :

• The issue arises because the SelectedItem of the Picker is updated before the ItemsSource. As a result, in the OnItemsSourceChanged method of the Picker class, the SelectedItem is cleared when the new ItemsSource is set, causing the picker to lose its selected item and leaving the SelectedIndex unchanged.

Description of change :

• I updated the SelectedIndex when the SelectedItem has a value and the SelectedIndex is -1, before applying the ClampSelectedIndex check while updating the ItemsSource.

Tested the behaviour in the following platforms.

• [x] Android
• [x] Windows
• [x] iOS
• [x] Mac

Issues Fixed

Fixes #13558

Output

Before

After

[jfversluis]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[rmarinho]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[PureWeen]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[jsuarezruiz]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[jsuarezruiz]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[jsuarezruiz]

/rebase

[jsuarezruiz]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[jsuarezruiz]

/rebase

[jsuarezruiz]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[jsuarezruiz]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[NanthiniMahalingam]

This unit tests is failing based on the changes in TemplatedItemsList.cs:

 Failed HookAndUnhookContentOnReplace [1 ms]
 Error Message:
 Assert.Equal() Failure: Values differ
Expected: Baz
Actual:   null

Hi @jsuarezruiz ,

The unit test HookAndUnhookContentOnReplace is passing successfully on my local machine, and I have attached a screenshot for your reference. Please let us know if you have any further concerns.

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[jfversluis]

/rebase

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[KarthikRajaKalaimani]

There are a couple of ListView related unit tests failing:

• HookAndUnhookContentOnReplace
• SetupContentOnCreation

Could you take a look?

Hi @jsuarezruiz ,

I’ve updated the fix and applied it to the Picker control. Could you please review the changes and let me know if you have any concerns?

[jsuarezruiz]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[jsuarezruiz]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[PureWeen]

@NanthiniMahalingam is this PR related https://github.com/dotnet/maui/pull/26777 ?

[KarthikRajaKalaimani]

@NanthiniMahalingam is this PR related #26777 ?

@PureWeen The scenario #26777 mentioned does not get resolved by this PR. I also tested the fix in this PR with scenario #26777, but it did not resolve the issue either. Additionally the fix implemented in #26777 does not fix this PR scenario. This PR resolves the case where the SelectedItem is set before the ItemsSource is set for the Picker.