maui icon indicating copy to clipboard operation
maui copied to clipboard

Navigationbar BarBackgroundColor is not updating - fix

Open kubaflo opened this issue 1 year ago • 1 comments

Issues Fixed

Fixes https://github.com/dotnet/maui/issues/23195 Fixes https://github.com/dotnet/maui/issues/11790 Fixes https://github.com/dotnet/maui/issues/23201

https://github.com/dotnet/maui/assets/42434498/fe7fd762-97fb-44a2-ac5c-161fe47ee2ab

kubaflo avatar Jun 28 '24 15:06 kubaflo

/azp run

mattleibow avatar Jul 18 '24 19:07 mattleibow

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jul 18 '24 19:07 azure-pipelines[bot]

Hi, @StephaneDelcroix feel free to add any improvements you think will make this PR better! :)

kubaflo avatar Sep 04 '24 15:09 kubaflo

@StephaneDelcroix I've added an XAML unit test. Should the Appium test be removed then?

kubaflo avatar Sep 05 '24 14:09 kubaflo

@StephaneDelcroix I've added an XAML unit test. Should the Appium test be removed then?

yes, please

StephaneDelcroix avatar Sep 09 '24 08:09 StephaneDelcroix

@StephaneDelcroix I've added an XAML unit test. Should the Appium test be removed then?

yes, please

Done :)

kubaflo avatar Sep 09 '24 09:09 kubaflo

I'm still playing with this fix...

StephaneDelcroix avatar Sep 10 '24 09:09 StephaneDelcroix

@StephaneDelcroix it doesn't work without changes in src/Controls/src/Core/Compatibility/Handlers/NavigationPage/iOS/NavigationRenderer.cs

maybe after you merge your PR: https://github.com/dotnet/maui/pull/24688 I will rebase this to include only changes in this file?

https://github.com/user-attachments/assets/c484182e-59c7-41a4-b022-784cf1b27741

kubaflo avatar Sep 10 '24 15:09 kubaflo

it doesn't work

what doesn't work ? #23195 and #11790 were already closed, and there's a test in #24688 showing that #23201 is fixed. do you have an issue that isn't fixed ?

StephaneDelcroix avatar Sep 13 '24 19:09 StephaneDelcroix

it doesn't work

what doesn't work ? #23195 and #11790 were already closed, and there's a test in #24688 showing that #23201 is fixed. do you have an issue that isn't fixed ?

Yea, I got you. I've written practically the same test (I didn't look at yours for reference 😅) and it passes too. But, when I created a UI test then the color didn't update without my changes in src/Controls/src/Core/Compatibility/Handlers/NavigationPage/iOS/NavigationRenderer.cs

I tested if after your PR had already been merged...

Currently This PR

kubaflo avatar Sep 14 '24 00:09 kubaflo

@StephaneDelcroix I've opened this PR: https://github.com/dotnet/maui/pull/24766 for you to have a look. However, feel free to close it if you want :)

kubaflo avatar Sep 14 '24 00:09 kubaflo