[Windows] Respect `ClearButtonVisibility = ClearButtonVisibility.Never` for `<Entry>`s

[MartyIX]

Description of Change

The style interception code works sometimes but not always.

Relevant XAML template in WinUI 3 is here.

Issues Fixed

Fixes #23112 Related to #13714

PR that introduced the modified code: #3444

[MartyIX]

Could anyone run tests for this PR just to know if they pass or not?

[MartyIX]

@mattleibow What do you think please?

[mattleibow]

/rebase

[mattleibow]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[MartyIX]

@mattleibow Does it look better to you now?

[mattleibow]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[mattleibow]

Are you able to add a UI test? I have a feeling this one is going to break randomly when we update wasdk.

[MartyIX]

Are you able to add a UI test?

I added 280f81c0dba7abd03b5c33cfade29ca051eb3ff3 as the first commit so that one can easily check that the test fails without the new "workaround".

The test is partially done according to #23112 and its Steps to Reproduce.

I have a feeling this one is going to break randomly when we update wasdk.

Yes, I can imagine that.

[mattleibow]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[mattleibow]

Thanks for the test, now to bend CI to our will and ask it to do the basic job of running the tests properly.

[MartyIX]

So I can see that a screenshot must be added. Not sure if some other test genuinely failed.

[mattleibow]

You can download the screenshots from the devops test attachments. Just go to the failed test and the attachments tab. Should be there. It is the one without the nav bars and status bars.

[mattleibow]

I think the layout will not really work on mobile:

Android	iOS

https://dev.azure.com/xamarin/public/_build/results?buildId=118577&view=ms.vss-test-web.build-test-results-tab&runId=2906687&resultId=100119&paneView=attachments

But it seems to be right for Windows:

I wonder if it will work if you have jus a flay vertical stack layout?

[mattleibow]

/azp run

[MartyIX]

Yes, I have realized that the layout is wrong once I saw the snapshots.

This is the current screenshot for Windows:

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[PureWeen]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[MartyIX]

Ok, my bad, I added a Windows snapshot but that had different dimensions (presumably because my display has different settings than the "CI one").

I added snapshots for Android & iOS. MacCatalyst build failed so hopefully next time.

[mattleibow]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[MartyIX]

Added a Windows snapshot. No snapshot for macOS so far.

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[mattleibow]

Trying the tests on Windows Core unpackaged again... Probably not related since the packaged version ran. But just to be safe. Might just merge if it fails again and see if main fixes it.

[mattleibow]

Well, now it is green so whatever CI.